feat: save activated/disabled fields in New Field - Step 1 page (#2226)

* feat: save activated/disabled fields in New Field - Step 1 page

Closes #2170

* fix: fix objectSlug

* Console.log

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
This commit is contained in:
Thaïs
2023-10-27 17:59:57 +02:00
committed by GitHub
parent 9681815cb3
commit 40c5f72080
2 changed files with 67 additions and 20 deletions

View File

@ -81,7 +81,6 @@ export const TableOptionsDropdownContent = () => {
useScopedHotkeys( useScopedHotkeys(
Key.Enter, Key.Enter,
() => { () => {
console.log('enter');
const name = viewEditInputRef.current?.value; const name = viewEditInputRef.current?.value;
handleViewNameSubmit(name); handleViewNameSubmit(name);
resetMenu(); resetMenu();

View File

@ -1,7 +1,8 @@
import { useEffect } from 'react'; import { useEffect, useState } from 'react';
import { useNavigate, useParams } from 'react-router-dom'; import { useNavigate, useParams } from 'react-router-dom';
import styled from '@emotion/styled'; import styled from '@emotion/styled';
import { useMetadataField } from '@/metadata/hooks/useMetadataField';
import { useMetadataObjectForSettings } from '@/metadata/hooks/useMetadataObjectForSettings'; import { useMetadataObjectForSettings } from '@/metadata/hooks/useMetadataObjectForSettings';
import { SaveAndCancelButtons } from '@/settings/components/SaveAndCancelButtons/SaveAndCancelButtons'; import { SaveAndCancelButtons } from '@/settings/components/SaveAndCancelButtons/SaveAndCancelButtons';
import { SettingsHeaderContainer } from '@/settings/components/SettingsHeaderContainer'; import { SettingsHeaderContainer } from '@/settings/components/SettingsHeaderContainer';
@ -41,19 +42,58 @@ export const SettingsObjectNewFieldStep1 = () => {
const activeMetadataObject = findActiveMetadataObjectBySlug(objectSlug); const activeMetadataObject = findActiveMetadataObjectBySlug(objectSlug);
const { activateMetadataField, disableMetadataField } = useMetadataField();
const [metadataFields, setMetadataFields] = useState(
activeMetadataObject?.fields ?? [],
);
const activeMetadataFields = metadataFields.filter((field) => field.isActive);
const disabledMetadataFields = metadataFields.filter(
(field) => !field.isActive,
);
const canSave = metadataFields.some(
(field, index) =>
field.isActive !== activeMetadataObject?.fields[index].isActive,
);
useEffect(() => { useEffect(() => {
if (loading) return; if (loading) return;
if (!activeMetadataObject) navigate(AppPath.NotFound);
}, [activeMetadataObject, loading, navigate]); if (!activeMetadataObject) {
navigate(AppPath.NotFound);
return;
}
if (!metadataFields.length) setMetadataFields(activeMetadataObject.fields);
}, [activeMetadataObject, metadataFields.length, loading, navigate]);
if (!activeMetadataObject) return null; if (!activeMetadataObject) return null;
const activeMetadataFields = activeMetadataObject.fields.filter( const handleToggleField = (fieldId: string) =>
(metadataField) => metadataField.isActive, setMetadataFields((previousFields) =>
); previousFields.map((field) =>
const disabledMetadataFields = activeMetadataObject.fields.filter( field.id === fieldId ? { ...field, isActive: !field.isActive } : field,
(metadataField) => !metadataField.isActive, ),
); );
const handleSave = async () => {
await Promise.all(
metadataFields.map((metadataField, index) => {
if (
metadataField.isActive === activeMetadataObject.fields[index].isActive
) {
return;
}
return metadataField.isActive
? activateMetadataField(metadataField)
: disableMetadataField(metadataField);
}),
);
navigate(`/settings/objects/${objectSlug}`);
};
return ( return (
<SubMenuTopBarContainer Icon={IconSettings} title="Settings"> <SubMenuTopBarContainer Icon={IconSettings} title="Settings">
@ -70,9 +110,9 @@ export const SettingsObjectNewFieldStep1 = () => {
]} ]}
/> />
<SaveAndCancelButtons <SaveAndCancelButtons
isSaveDisabled isSaveDisabled={!canSave}
onCancel={() => navigate(`/settings/objects/${objectSlug}`)} onCancel={() => navigate(`/settings/objects/${objectSlug}`)}
onSave={() => undefined} onSave={handleSave}
/> />
</SettingsHeaderContainer> </SettingsHeaderContainer>
<StyledSection> <StyledSection>
@ -89,12 +129,16 @@ export const SettingsObjectNewFieldStep1 = () => {
</StyledObjectFieldTableRow> </StyledObjectFieldTableRow>
{!!activeMetadataFields.length && ( {!!activeMetadataFields.length && (
<TableSection isInitiallyExpanded={false} title="Active"> <TableSection isInitiallyExpanded={false} title="Active">
{activeMetadataFields.map((activeMetadataField) => ( {activeMetadataFields.map((field) => (
<SettingsObjectFieldItemTableRow <SettingsObjectFieldItemTableRow
key={activeMetadataField.id} key={field.id}
fieldItem={activeMetadataField} fieldItem={field}
ActionIcon={ ActionIcon={
<LightIconButton Icon={IconMinus} accent="tertiary" /> <LightIconButton
Icon={IconMinus}
accent="tertiary"
onClick={() => handleToggleField(field.id)}
/>
} }
/> />
))} ))}
@ -102,12 +146,16 @@ export const SettingsObjectNewFieldStep1 = () => {
)} )}
{!!disabledMetadataFields.length && ( {!!disabledMetadataFields.length && (
<TableSection title="Disabled"> <TableSection title="Disabled">
{disabledMetadataFields.map((disabledMetadataField) => ( {disabledMetadataFields.map((field) => (
<SettingsObjectFieldItemTableRow <SettingsObjectFieldItemTableRow
key={disabledMetadataField.name} key={field.name}
fieldItem={disabledMetadataField} fieldItem={field}
ActionIcon={ ActionIcon={
<LightIconButton Icon={IconPlus} accent="tertiary" /> <LightIconButton
Icon={IconPlus}
accent="tertiary"
onClick={() => handleToggleField(field.id)}
/>
} }
/> />
))} ))}