Record board columns design fix (full height borders) (#6350)
This PR was created by [GitStart](https://gitstart.com/) to address the requirements from this ticket: [TWNTY-5273](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-5273). This ticket was imported from: [TWNTY-5273](https://github.com/twentyhq/twenty/issues/5273) --- ## Description: - We added a min-height to fix the main issue, in two components, one of them needs \`calc\` because the border causes the creation of a scrollbar - The change on the overflow fixes the issue mentioned [here](https://github.com/twentyhq/twenty/issues/5273#issuecomment-2232945913) ## Refs: #5273 ## Demo: \ <https://jam.dev/c/01cac1e5-ed66-439c-88fb-9406a06429c5>\ \ Fixes #5273 Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
This commit is contained in:
committed by
GitHub
parent
936994ff44
commit
41931c53e8
@ -25,9 +25,11 @@ export type RecordBoardProps = {
|
||||
|
||||
const StyledContainer = styled.div`
|
||||
border-top: 1px solid ${({ theme }) => theme.border.color.light};
|
||||
overflow: auto;
|
||||
display: flex;
|
||||
flex: 1;
|
||||
flex-direction: row;
|
||||
min-height: calc(100% - 1px);
|
||||
`;
|
||||
|
||||
const StyledWrapper = styled.div`
|
||||
|
||||
@ -40,7 +40,8 @@ const StyledContainer = styled.div`
|
||||
overflow: auto;
|
||||
`;
|
||||
|
||||
const StyledContainerWithPadding = styled.div`
|
||||
const StyledContainerWithPadding = styled.div<{ fullHeight?: boolean }>`
|
||||
min-height: ${({ fullHeight }) => (fullHeight ? '100%' : 'auto')};
|
||||
padding-left: ${({ theme }) => theme.table.horizontalCellPadding};
|
||||
`;
|
||||
|
||||
@ -193,7 +194,7 @@ export const RecordIndexContainer = ({
|
||||
</>
|
||||
)}
|
||||
{recordIndexViewType === ViewType.Kanban && (
|
||||
<StyledContainerWithPadding>
|
||||
<StyledContainerWithPadding fullHeight>
|
||||
<RecordIndexBoardContainer
|
||||
recordBoardId={recordIndexId}
|
||||
viewBarId={recordIndexId}
|
||||
|
||||
Reference in New Issue
Block a user