admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

FixuseLazyFetchAllRecords any wrong infer (#12728)

Browse Source 
# Introduction
closes https://github.com/twentyhq/twenty/issues/12721
Regression seems to be introduced by
https://github.com/twentyhq/twenty/pull/12653

## Post mortem
### Previously
No mapping on `namePlural` dynamic response data key
```ts
      const rawResult = await fetchMore({
        variables: {
          lastCursor: lastCursor,
          limit,
        },
      });
```

### Now
Mapping is done by the tool we're consuming already
```ts
      const rawResult = await fetchMoreRecordsLazy();

// 
const fetchMoreRecordsLazy = useRecoilCallback(
    ({ snapshot, set }) =>
      async () => {

          //...
           return {
              data: fetchMoreDataResult?.[objectMetadataItem.namePlural],
              totalCount:
                fetchMoreDataResult?.[objectMetadataItem.namePlural]
                  ?.totalCount,
              records: getRecordsFromRecordConnection({
                recordConnection: {
                  edges:
                    fetchMoreDataResult?.[objectMetadataItem.namePlural]?.edges,
                  pageInfo:
                    fetchMoreDataResult?.[objectMetadataItem.namePlural]
                      ?.pageInfo,
                },
              }) as T[],
```

## Concerns
TypeScript did not throw any errors because `RecordConnectionGql` is
typed as any, we should consider adding a generic type defaulted to
unknown
```ts
import { RecordGqlEdge } from '@/object-record/graphql/types/RecordGqlEdge';
import { Nullable } from 'twenty-ui/utilities';

export type RecordGqlConnection = {
  __typename?: string;
  edges: RecordGqlEdge[];
  pageInfo: {
    __typename?: string;
    hasNextPage?: boolean;
    hasPreviousPage?: boolean;
    startCursor?: Nullable<string>;
    endCursor?: Nullable<string>;
    totalCount?: number;
  };
  totalCount?: number;
  [aggregateFieldName: string]: any; // Any is problematic here should be unknown
};
```

Example:
```ts
export type RecordGqlConnection<
  T extends Record<string, unknown> = Record<string, unknown>,
> = {
  __typename?: string;
  edges: RecordGqlEdge[];
  pageInfo: {
    __typename?: string;
    hasNextPage?: boolean;
    hasPreviousPage?: boolean;
    startCursor?: Nullable<string>;
    endCursor?: Nullable<string>;
    totalCount?: number;
  };
  totalCount?: number;
} & T;
```
This commit is contained in:
Paul Rastoin
2025-06-19 14:22:05 +02:00
committed by GitHub
parent dae282ca0f
commit 4da0152c33
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/twenty-front/src/modules/object-record/hooks/useLazyFetchAllRecords.ts
View File

@ -94,9 +94,9 @@ export const useLazyFetchAllRecords = <T>({
const rawResult = await fetchMoreRecordsLazy();
const fetchMoreResult = rawResult?.data?.[objectMetadataItem.namePlural];
const fetchMoreResult = rawResult?.data;
for (const edge of fetchMoreResult.edges) {
for (const edge of fetchMoreResult?.edges ?? []) {
records.push(edge.node);
}
@ -106,11 +106,11 @@ export const useLazyFetchAllRecords = <T>({
displayType: totalCount ? 'percentage' : 'number',
});
if (fetchMoreResult.pageInfo.hasNextPage === false) {
if (fetchMoreResult?.pageInfo.hasNextPage === false) {
break;
}
lastCursor = fetchMoreResult.pageInfo.endCursor ?? null;
lastCursor = fetchMoreResult?.pageInfo.endCursor ?? null;
}
setIsDownloading(false);