admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix default value being set to null when not provider to fieldMetadataUpdate

Browse Source
This commit is contained in:
Charles Bochet
2024-03-01 08:58:19 +01:00
parent ad4b3d0d59
commit 5e261783da
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/twenty-server/src/metadata/field-metadata/field-metadata.service.ts
View File

@ -235,10 +235,14 @@ export class FieldMetadataService extends TypeOrmQueryService<FieldMetadataEntit
const updatedFieldMetadata = await super.updateOne(id, { const updatedFieldMetadata = await super.updateOne(id, {
...updatableFieldInput, ...updatableFieldInput,
defaultValue: updatableFieldInput.defaultValue defaultValue:
? // Todo: we need to rework DefaultValue typing and format to be simpler, there is no need to have this complexity // Todo: we need to handle default value for all field types. Right now we are only allowing update for SELECt
{ value: updatableFieldInput.defaultValue as unknown as string } existingFieldMetadata.type !== FieldMetadataType.SELECT
: null, ? existingFieldMetadata.defaultValue
: updatableFieldInput.defaultValue
? // Todo: we need to rework DefaultValue typing and format to be simpler, there is no need to have this complexity
{ value: updatableFieldInput.defaultValue as unknown as string }
: null,
// If the name is updated, the targetColumnMap should be updated as well // If the name is updated, the targetColumnMap should be updated as well
targetColumnMap: updatableFieldInput.name targetColumnMap: updatableFieldInput.name
? generateTargetColumnMap( ? generateTargetColumnMap(