admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove mandatory parameters (#2743)

Browse Source
This commit is contained in:
martmull
2023-11-28 10:02:21 +01:00
committed by GitHub
parent 7b02391b22
commit 7752be8f9a
4 changed files with 8 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/twenty-zapier/src/creates/create_company.ts
View File

@ -26,7 +26,7 @@ export default {
key: 'name', key: 'name',
label: 'Company Name', label: 'Company Name',
type: 'string', type: 'string',
required: true, required: false,
list: false, list: false,
altersDynamicFields: false, altersDynamicFields: false,
}, },
@ -34,7 +34,7 @@ export default {
key: 'address', key: 'address',
label: 'Address', label: 'Address',
type: 'string', type: 'string',
required: true, required: false,
list: false, list: false,
altersDynamicFields: false, altersDynamicFields: false,
}, },
@ -42,7 +42,7 @@ export default {
key: 'domainName', key: 'domainName',
label: 'Url', label: 'Url',
type: 'string', type: 'string',
required: true, required: false,
list: false, list: false,
altersDynamicFields: false, altersDynamicFields: false,
}, },

2
packages/twenty-zapier/src/creates/create_person.ts
View File

@ -42,7 +42,7 @@ export default {
key: 'email', key: 'email',
label: 'Email', label: 'Email',
type: 'string', type: 'string',
required: true, required: false,
list: false, list: false,
altersDynamicFields: false, altersDynamicFields: false,
}, },

12
packages/twenty-zapier/src/test/creates/create_company.test.ts
View File

@ -36,16 +36,8 @@ describe('creates.create_company', () => {
100000000000, 100000000000,
); );
}); });
test('should run with not required missing params', async () => { test('should run with not required params', async () => {
const bundle = getBundle({ const bundle = getBundle({});
name: 'Company Name',
address: 'Company Address',
domainName: 'Company Domain Name',
linkedinLink: {url: '/linkedin_url', label: "Test linkedinUrl"},
xLink: {url: '/x_url', label: "Test xUrl"},
idealCustomerProfile: true,
employees: 25,
});
const result = await appTester( const result = await appTester(
App.creates.create_company.operation.perform, App.creates.create_company.operation.perform,
bundle, bundle,

8
packages/twenty-zapier/src/test/creates/create_person.test.ts
View File

@ -31,12 +31,8 @@ describe('creates.create_person', () => {
expect(checkDbResult.data.person.phone).toEqual('+33610203040'); expect(checkDbResult.data.person.phone).toEqual('+33610203040');
}); });
test('should run with not required missing params', async () => { test('should run with not required params', async () => {
const bundle = getBundle({ const bundle = getBundle({});
name: {firstName: 'John', lastName: 'Doe'},
email: 'johndoe@gmail.com',
city: 'Paris',
});
const results = await appTester( const results = await appTester(
App.creates.create_person.operation.perform, App.creates.create_person.operation.perform,
bundle, bundle,