Fix view filter update and deletion propagation (#12082)

# Introduction

Diff description: ~500 tests and +500 additions

close https://github.com/twentyhq/core-team-issues/issues/731

## What has been done here
In a nutshell on a field metadata type ( `SELECT MULTI_SELECT` ) update,
we will be browsing all `ViewFilters` in a post hook searching for some
referencing related updated `fieldMetadata` select. In order to update
or delete the `viewFilter` depending on the associated mutations.

## How to test:
- Add FieldMetadata `SELECT | MULTI_SELECT` to an existing or a new
`objectMetadata`
- Create a filtered view on created `fieldMetadata` with any options you
would like
- Remove some options ( in the best of the world some that are selected
by the filter ) from the `fieldMetadata` settings page
- Go back to the filtered view, removed or updated options should have
been hydrated in the `displayValue` and the filtered data should make
sense

## All filtered options are deleted edge case
If an update implies that a viewFilter does not have any existing
related options anymore, then we remove the viewFilter

## Testing
```sh 
PASS  test/integration/metadata/suites/field-metadata/update-one-field-metadata-related-record.integration-spec.ts (27 s)
  update-one-field-metadata-related-record
    SELECT
      ✓ should delete related view filter if all select field options got deleted (2799 ms)
      ✓ should update related multi selected options view filter (1244 ms)
      ✓ should update related solo selected option view filter (1235 ms)
      ✓ should handle partial deletion of selected options in view filter (1210 ms)
      ✓ should handle reordering of options while maintaining view filter values (1487 ms)
      ✓ should handle no changes update of options while maintaining existing view filter values (1174 ms)
      ✓ should handle adding new options while maintaining existing view filter (1174 ms)
      ✓ should update display value with options label if less than 3 options are selected (1249 ms)
      ✓ should throw error if view filter value is not a stringified JSON array (1300 ms)
    MULTI_SELECT
      ✓ should delete related view filter if all select field options got deleted (1127 ms)
      ✓ should update related multi selected options view filter (1215 ms)
      ✓ should update related solo selected option view filter (1404 ms)
      ✓ should handle partial deletion of selected options in view filter (1936 ms)
      ✓ should handle reordering of options while maintaining view filter values (1261 ms)
      ✓ should handle no changes update of options while maintaining existing view filter values (1831 ms)
      ✓ should handle adding new options while maintaining existing view filter (1610 ms)
      ✓ should update display value with options label if less than 3 options are selected (1889 ms)
      ✓ should throw error if view filter value is not a stringified JSON array (1365 ms)

Test Suites: 1 passed, 1 total
Tests:       18 passed, 18 total
Snapshots:   18 passed, 18 total
Time:        27.039 s
```
## Out of scope
- We should handle ViewFilter validation when extracting its definition
from the metadata
https://github.com/twentyhq/core-team-issues/issues/1009

## Concerns
- Are we able through the api to update an RATING fieldMetadata ? ( if
yes than that's an issue and we should handle RATING the same way than
for SELECT and MULTI_SELECT )
- It's not possible to group a view from a MULTI_SELECT field

The above points create a double nor a triple "lecture" to the post hook
effect:
- ViewGroup -> only SELECT
- VIewFilter -> only SELECT || MULTI_SELECT
- Rating nothing
I think we should determine the scope of all of that

---------

Co-authored-by: Charles Bochet <charles@twenty.com>

packages/twenty-front/src/modules/views/components/ViewBarRecordFilterEffect.tsx

@@ -3,14 +3,13 @@ import { useFilterableFieldMetadataItems } from '@/object-record/record-filter/h
 import { currentRecordFiltersComponentState } from '@/object-record/record-filter/states/currentRecordFiltersComponentState';
 import { useRecordIndexContextOrThrow } from '@/object-record/record-index/contexts/RecordIndexContext';
 import { prefetchViewFromViewIdFamilySelector } from '@/prefetch/states/selector/prefetchViewFromViewIdFamilySelector';
-import { useRecoilComponentFamilyStateV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentFamilyStateV2';
+import { useRecoilComponentStateV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentStateV2';
 import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2';
-import { useSetRecoilComponentStateV2 } from '@/ui/utilities/state/component-state/hooks/useSetRecoilComponentStateV2';
-import { hasInitializedCurrentRecordFiltersComponentFamilyState } from '@/views/states/hasInitializedCurrentRecordFiltersComponentFamilyState';
 import { mapViewFiltersToFilters } from '@/views/utils/mapViewFiltersToFilters';
 import { useEffect } from 'react';
 import { useRecoilValue } from 'recoil';
 import { isDefined } from 'twenty-shared/utils';
+import { isDeeplyEqual } from '~/utils/isDeeplyEqual';
 
 export const ViewBarRecordFilterEffect = () => {
   const currentViewId = useRecoilComponentValueV2(
@@ -25,47 +24,32 @@ export const ViewBarRecordFilterEffect = () => {
     }),
   );
 
-  const [
-    hasInitializedCurrentRecordFilters,
-    setHasInitializedCurrentRecordFilters,
-  ] = useRecoilComponentFamilyStateV2(
-    hasInitializedCurrentRecordFiltersComponentFamilyState,
-    {
-      viewId: currentViewId ?? undefined,
-    },
-  );
-
-  const setCurrentRecordFilters = useSetRecoilComponentStateV2(
-    currentRecordFiltersComponentState,
-  );
+  const [currentRecordFilters, setCurrentRecordFilters] =
+    useRecoilComponentStateV2(currentRecordFiltersComponentState);
 
   const { filterableFieldMetadataItems } = useFilterableFieldMetadataItems(
     objectMetadataItem.id,
   );
 
   useEffect(() => {
-    if (isDefined(currentView) && !hasInitializedCurrentRecordFilters) {
+    if (isDefined(currentView)) {
       if (currentView.objectMetadataId !== objectMetadataItem.id) {
         return;
       }
 
-      if (isDefined(currentView)) {
-        setCurrentRecordFilters(
-          mapViewFiltersToFilters(
-            currentView.viewFilters,
-            filterableFieldMetadataItems,
-          ),
-        );
-
-        setHasInitializedCurrentRecordFilters(true);
+      const newRecordFilters = mapViewFiltersToFilters(
+        currentView.viewFilters,
+        filterableFieldMetadataItems,
+      );
+      if (!isDeeplyEqual(currentRecordFilters, newRecordFilters)) {
+        setCurrentRecordFilters(newRecordFilters);
       }
     }
   }, [
     currentViewId,
+    currentRecordFilters,
     setCurrentRecordFilters,
     filterableFieldMetadataItems,
-    hasInitializedCurrentRecordFilters,
-    setHasInitializedCurrentRecordFilters,
     currentView,
     objectMetadataItem,
   ]);

packages/twenty-front/src/modules/views/states/hasInitializedCurrentRecordFiltersComponentFamilyState.ts

@@ -1,9 +0,0 @@
-import { RecordFiltersComponentInstanceContext } from '@/object-record/record-filter/states/context/RecordFiltersComponentInstanceContext';
-import { createComponentFamilyStateV2 } from '@/ui/utilities/state/component-state/utils/createComponentFamilyStateV2';
-
-export const hasInitializedCurrentRecordFiltersComponentFamilyState =
-  createComponentFamilyStateV2<boolean, { viewId?: string }>({
-    key: 'hasInitializedCurrentRecordFiltersComponentFamilyState',
-    defaultValue: false,
-    componentInstanceContext: RecordFiltersComponentInstanceContext,
-  });