admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix workflow id not being set (#10989)

Browse Source 
The workflow id was not set inside `WorkflowRunVisualizerEffect` and
`WorkflowVersionVisualizerEffect` this PR fixes this
This commit is contained in:
Raphaël Bosi
2025-03-18 17:00:56 +01:00
committed by GitHub
parent 2680f1d6be
commit b4412ab3c8
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowRunVisualizerEffect.tsx
View File

@ -2,6 +2,7 @@ import { useStepsOutputSchema } from '@/workflow/hooks/useStepsOutputSchema';
import { useWorkflowRun } from '@/workflow/hooks/useWorkflowRun'; import { useWorkflowRun } from '@/workflow/hooks/useWorkflowRun';
import { useWorkflowVersion } from '@/workflow/hooks/useWorkflowVersion'; import { useWorkflowVersion } from '@/workflow/hooks/useWorkflowVersion';
import { flowState } from '@/workflow/states/flowState'; import { flowState } from '@/workflow/states/flowState';
import { workflowIdState } from '@/workflow/states/workflowIdState';
import { workflowRunIdState } from '@/workflow/states/workflowRunIdState'; import { workflowRunIdState } from '@/workflow/states/workflowRunIdState';
import { workflowDiagramState } from '@/workflow/workflow-diagram/states/workflowDiagramState'; import { workflowDiagramState } from '@/workflow/workflow-diagram/states/workflowDiagramState';
import { generateWorkflowRunDiagram } from '@/workflow/workflow-diagram/utils/generateWorkflowRunDiagram'; import { generateWorkflowRunDiagram } from '@/workflow/workflow-diagram/utils/generateWorkflowRunDiagram';
@ -18,6 +19,7 @@ export const WorkflowRunVisualizerEffect = ({
const workflowVersion = useWorkflowVersion(workflowRun?.workflowVersionId); const workflowVersion = useWorkflowVersion(workflowRun?.workflowVersionId);
const setWorkflowRunId = useSetRecoilState(workflowRunIdState); const setWorkflowRunId = useSetRecoilState(workflowRunIdState);
const setWorkflowId = useSetRecoilState(workflowIdState);
const setFlow = useSetRecoilState(flowState); const setFlow = useSetRecoilState(flowState);
const setWorkflowDiagram = useSetRecoilState(workflowDiagramState); const setWorkflowDiagram = useSetRecoilState(workflowDiagramState);
const { populateStepsOutputSchema } = useStepsOutputSchema(); const { populateStepsOutputSchema } = useStepsOutputSchema();
@ -26,6 +28,13 @@ export const WorkflowRunVisualizerEffect = ({
setWorkflowRunId(workflowRunId); setWorkflowRunId(workflowRunId);
}, [setWorkflowRunId, workflowRunId]); }, [setWorkflowRunId, workflowRunId]);
useEffect(() => {
if (!isDefined(workflowVersion)) {
return;
}
setWorkflowId(workflowVersion.workflowId);
}, [setWorkflowId, workflowVersion]);
useEffect(() => { useEffect(() => {
if (!isDefined(workflowRun?.output)) { if (!isDefined(workflowRun?.output)) {
setFlow(undefined); setFlow(undefined);

6
packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowVersionVisualizerEffect.tsx
View File

@ -1,6 +1,7 @@
import { useStepsOutputSchema } from '@/workflow/hooks/useStepsOutputSchema'; import { useStepsOutputSchema } from '@/workflow/hooks/useStepsOutputSchema';
import { useWorkflowVersion } from '@/workflow/hooks/useWorkflowVersion'; import { useWorkflowVersion } from '@/workflow/hooks/useWorkflowVersion';
import { flowState } from '@/workflow/states/flowState'; import { flowState } from '@/workflow/states/flowState';
import { workflowIdState } from '@/workflow/states/workflowIdState';
import { workflowDiagramState } from '@/workflow/workflow-diagram/states/workflowDiagramState'; import { workflowDiagramState } from '@/workflow/workflow-diagram/states/workflowDiagramState';
import { getWorkflowVersionDiagram } from '@/workflow/workflow-diagram/utils/getWorkflowVersionDiagram'; import { getWorkflowVersionDiagram } from '@/workflow/workflow-diagram/utils/getWorkflowVersionDiagram';
import { useEffect } from 'react'; import { useEffect } from 'react';
@ -16,6 +17,7 @@ export const WorkflowVersionVisualizerEffect = ({
const setFlow = useSetRecoilState(flowState); const setFlow = useSetRecoilState(flowState);
const setWorkflowDiagram = useSetRecoilState(workflowDiagramState); const setWorkflowDiagram = useSetRecoilState(workflowDiagramState);
const setWorkflowId = useSetRecoilState(workflowIdState);
const { populateStepsOutputSchema } = useStepsOutputSchema(); const { populateStepsOutputSchema } = useStepsOutputSchema();
useEffect(() => { useEffect(() => {
if (!isDefined(workflowVersion)) { if (!isDefined(workflowVersion)) {
@ -29,7 +31,9 @@ export const WorkflowVersionVisualizerEffect = ({
trigger: workflowVersion.trigger, trigger: workflowVersion.trigger,
steps: workflowVersion.steps, steps: workflowVersion.steps,
}); });
}, [setFlow, workflowVersion]);
setWorkflowId(workflowVersion.workflowId);
}, [setFlow, setWorkflowId, workflowVersion]);
useEffect(() => { useEffect(() => {
if (!isDefined(workflowVersion)) { if (!isDefined(workflowVersion)) {