admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Possiblity to reconnect on Failed unkown (#11576)

Browse Source 
Possiblity to reconnect you account on Failed Unkown errors.

This PR triggers a similar flow than the Failed errors for unsufficient
permission already existing in twenty.

Allows our users to force the synchro again even though they have a
strange error. It's been asked by some customers since we have had a
couple of issues in messaging lately

Fixes https://github.com/twentyhq/twenty/issues/11411
This commit is contained in:
Guillim
2025-04-15 13:39:18 +02:00
committed by GitHub
parent e8db0176a1
commit e1ce98825b
2 changed files with 23 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
packages/twenty-server/src/modules/messaging/common/services/message-channel-sync-status.service.ts
View File

@ -174,9 +174,12 @@ export class MessageChannelSyncStatusService {
});
}
public async markAsFailedUnknownAndFlushMessagesToImport(
public async markAsFailedAndFlushMessagesToImport(
messageChannelIds: string[],
workspaceId: string,
syncStatus:
| MessageChannelSyncStatus.FAILED_INSUFFICIENT_PERMISSIONS
| MessageChannelSyncStatus.FAILED_UNKNOWN,
) {
if (!messageChannelIds.length) {
return;
@ -195,41 +198,16 @@ export class MessageChannelSyncStatusService {
await messageChannelRepository.update(messageChannelIds, {
syncStage: MessageChannelSyncStage.FAILED,
syncStatus: MessageChannelSyncStatus.FAILED_UNKNOWN,
syncStatus: syncStatus,
});
const metricsKey =
syncStatus === MessageChannelSyncStatus.FAILED_INSUFFICIENT_PERMISSIONS
? MetricsKeys.MessageChannelSyncJobFailedInsufficientPermissions
: MetricsKeys.MessageChannelSyncJobFailedUnknown;
await this.metricsService.batchIncrementCounter({
key: MetricsKeys.MessageChannelSyncJobFailedUnknown,
eventIds: messageChannelIds,
});
}
public async markAsFailedInsufficientPermissionsAndFlushMessagesToImport(
messageChannelIds: string[],
workspaceId: string,
) {
if (!messageChannelIds.length) {
return;
}
for (const messageChannelId of messageChannelIds) {
await this.cacheStorage.del(
`messages-to-import:${workspaceId}:${messageChannelId}`,
);
}
const messageChannelRepository =
await this.twentyORMManager.getRepository<MessageChannelWorkspaceEntity>(
'messageChannel',
);
await messageChannelRepository.update(messageChannelIds, {
syncStage: MessageChannelSyncStage.FAILED,
syncStatus: MessageChannelSyncStatus.FAILED_INSUFFICIENT_PERMISSIONS,
});
await this.metricsService.batchIncrementCounter({
key: MetricsKeys.MessageChannelSyncJobFailedInsufficientPermissions,
key: metricsKey,
eventIds: messageChannelIds,
});

17
packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-import-exception-handler.service.ts
View File

@ -3,7 +3,10 @@ import { Injectable } from '@nestjs/common';
import { ExceptionHandlerService } from 'src/engine/core-modules/exception-handler/exception-handler.service';
import { TwentyORMManager } from 'src/engine/twenty-orm/twenty-orm.manager';
import { MessageChannelSyncStatusService } from 'src/modules/messaging/common/services/message-channel-sync-status.service';
import { MessageChannelWorkspaceEntity } from 'src/modules/messaging/common/standard-objects/message-channel.workspace-entity';
import {
MessageChannelSyncStatus,
MessageChannelWorkspaceEntity,
} from 'src/modules/messaging/common/standard-objects/message-channel.workspace-entity';
import { MESSAGING_THROTTLE_MAX_ATTEMPTS } from 'src/modules/messaging/message-import-manager/constants/messaging-throttle-max-attempts';
import {
MessageImportDriverException,
@ -90,9 +93,10 @@ export class MessageImportExceptionHandlerService {
if (
messageChannel.throttleFailureCount >= MESSAGING_THROTTLE_MAX_ATTEMPTS
) {
await this.messageChannelSyncStatusService.markAsFailedUnknownAndFlushMessagesToImport(
await this.messageChannelSyncStatusService.markAsFailedAndFlushMessagesToImport(
[messageChannel.id],
workspaceId,
MessageChannelSyncStatus.FAILED_UNKNOWN,
);
throw new MessageImportException(
`Unknown temporary error occurred multiple times while importing messages for message channel ${messageChannel.id} in workspace ${workspaceId}`,
@ -139,9 +143,10 @@ export class MessageImportExceptionHandlerService {
messageChannel: Pick<MessageChannelWorkspaceEntity, 'id'>,
workspaceId: string,
): Promise<void> {
await this.messageChannelSyncStatusService.markAsFailedInsufficientPermissionsAndFlushMessagesToImport(
await this.messageChannelSyncStatusService.markAsFailedAndFlushMessagesToImport(
[messageChannel.id],
workspaceId,
MessageChannelSyncStatus.FAILED_INSUFFICIENT_PERMISSIONS,
);
}
@ -150,9 +155,10 @@ export class MessageImportExceptionHandlerService {
messageChannel: Pick<MessageChannelWorkspaceEntity, 'id'>,
workspaceId: string,
): Promise<void> {
await this.messageChannelSyncStatusService.markAsFailedUnknownAndFlushMessagesToImport(
await this.messageChannelSyncStatusService.markAsFailedAndFlushMessagesToImport(
[messageChannel.id],
workspaceId,
MessageChannelSyncStatus.FAILED_UNKNOWN,
);
this.exceptionHandlerService.captureExceptions([
@ -170,9 +176,10 @@ export class MessageImportExceptionHandlerService {
messageChannel: Pick<MessageChannelWorkspaceEntity, 'id'>,
workspaceId: string,
): Promise<void> {
await this.messageChannelSyncStatusService.markAsFailedUnknownAndFlushMessagesToImport(
await this.messageChannelSyncStatusService.markAsFailedAndFlushMessagesToImport(
[messageChannel.id],
workspaceId,
MessageChannelSyncStatus.FAILED_UNKNOWN,
);
throw new MessageImportException(