admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix bug and remove useless stuff (#3861)

Browse Source
This commit is contained in:
martmull
2024-02-06 18:06:15 +01:00
committed by GitHub
parent 7b8fffc3b8
commit eb54401afe
5 changed files with 0 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
packages/twenty-front/src/modules/apollo/optimistic-effect/hooks/__tests__/useOptimisticEvict.test.tsx
View File

@ -1,50 +0,0 @@
import { useApolloClient } from '@apollo/client';
import { MockedProvider } from '@apollo/client/testing';
import { act, renderHook } from '@testing-library/react';
import { RecoilRoot } from 'recoil';
import { useOptimisticEvict } from '@/apollo/optimistic-effect/hooks/useOptimisticEvict';
const Wrapper = ({ children }: { children: React.ReactNode }) => (
<MockedProvider addTypename={false}>
<RecoilRoot>{children}</RecoilRoot>
</MockedProvider>
);
describe('useOptimisticEvict', () => {
it('should perform cache eviction', async () => {
const mockedData = {
'someType:1': { __typename: 'someType', id: '1', fieldName: 'value1' },
'someType:2': { __typename: 'someType', id: '2', fieldName: 'value2' },
'otherType:1': { __typename: 'otherType', id: '1', fieldName: 'value3' },
};
const { result } = renderHook(
() => {
const { cache } = useApolloClient();
cache.restore(mockedData);
return {
...useOptimisticEvict(),
cache,
};
},
{
wrapper: Wrapper,
},
);
const { performOptimisticEvict, cache } = result.current;
act(() => {
performOptimisticEvict('someType', 'fieldName', 'value1');
});
const cacheSnapshot = cache.extract();
expect(cacheSnapshot).toEqual({
'someType:2': { __typename: 'someType', id: '2', fieldName: 'value2' },
'otherType:1': { __typename: 'otherType', id: '1', fieldName: 'value3' },
});
});
});

24
packages/twenty-front/src/modules/apollo/optimistic-effect/hooks/useOptimisticEvict.ts
View File

@ -1,24 +0,0 @@
import { useApolloClient } from '@apollo/client';
export const useOptimisticEvict = () => {
const cache = useApolloClient().cache;
const performOptimisticEvict = (
typename: string,
fieldName: string,
fieldValue: string,
) => {
const serializedCache = cache.extract();
Object.values(serializedCache)
.filter((item) => item.__typename === typename)
.forEach((item) => {
if (item[fieldName] === fieldValue) {
cache.evict({ id: cache.identify(item) });
}
});
};
return {
performOptimisticEvict,
};
};

4
packages/twenty-front/src/pages/settings/developers/SettingsDevelopersApiKeyDetail.tsx
View File

@ -4,7 +4,6 @@ import styled from '@emotion/styled';
import { DateTime } from 'luxon';
import { useRecoilState } from 'recoil';
import { useOptimisticEvict } from '@/apollo/optimistic-effect/hooks/useOptimisticEvict';
import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
import { useCreateOneRecord } from '@/object-record/hooks/useCreateOneRecord';
import { useFindOneRecord } from '@/object-record/hooks/useFindOneRecord';
@ -48,8 +47,6 @@ export const SettingsDevelopersApiKeyDetail = () => {
const [generatedApiKey] = useRecoilState(
generatedApiKeyFamilyState(apiKeyId),
);
const { performOptimisticEvict } = useOptimisticEvict();
const [generateOneApiKeyToken] = useGenerateApiKeyTokenMutation();
const { createOneRecord: createOneApiKey } = useCreateOneRecord<ApiKey>({
objectNameSingular: CoreObjectNameSingular.ApiKey,
@ -68,7 +65,6 @@ export const SettingsDevelopersApiKeyDetail = () => {
idToUpdate: apiKeyId,
updateOneRecordInput: { revokedAt: DateTime.now().toString() },
});
performOptimisticEvict('ApiKey', 'id', apiKeyId);
if (redirect) {
navigate('/settings/developers');
}

1
packages/twenty-front/src/pages/settings/developers/SettingsDevelopersApiKeys.tsx
View File

@ -36,7 +36,6 @@ export const SettingsDevelopersApiKeys = () => {
const { records: apiKeys } = useFindManyRecords({
objectNameSingular: CoreObjectNameSingular.ApiKey,
filter: { revokedAt: { is: 'NULL' } },
orderBy: {},
});
return (

1
packages/twenty-front/src/pages/settings/developers/SettingsDevelopersWebhooks.tsx
View File

@ -33,7 +33,6 @@ export const SettingsDevelopersWebhooks = () => {
const { records: webhooks } = useFindManyRecords({
objectNameSingular: CoreObjectNameSingular.Webhook,
orderBy: {},
});
return (