Add missing default values (#2567)

* add missing default values * add missing default values
2023-11-17 19:11:25 +01:00
parent 50d6ab52d7
commit f62108d539
29 changed files with 88 additions and 58 deletions
--- a/server/src/database/typeorm-seeds/metadata/field-metadata/view-filter.ts
+++ b/server/src/database/typeorm-seeds/metadata/field-metadata/view-filter.ts
@ -115,7 +115,7 @@ export const seedViewFilterFieldMetadata = async (
        icon: null,
        isNullable: false,
        isSystem: false,
-        defaultValue: undefined,
+        defaultValue: { value: '' },
      },
      {
        id: SeedViewFilterFieldMetadataIds.View,
@ -151,7 +151,7 @@ export const seedViewFilterFieldMetadata = async (
        icon: null,
        isNullable: false,
        isSystem: false,
-        defaultValue: { value: '' },
+        defaultValue: { value: 'Contains' },
      },
      {
        id: SeedViewFilterFieldMetadataIds.Value,
--- a/server/src/database/typeorm-seeds/metadata/field-metadata/view-sort.ts
+++ b/server/src/database/typeorm-seeds/metadata/field-metadata/view-sort.ts
@ -113,7 +113,7 @@ export const seedViewSortFieldMetadata = async (
        icon: null,
        isNullable: false,
        isSystem: false,
-        defaultValue: undefined,
+        defaultValue: { value: '' },
      },
      {
        id: SeedViewSortFieldMetadataIds.View,
@ -149,7 +149,7 @@ export const seedViewSortFieldMetadata = async (
        icon: null,
        isNullable: false,
        isSystem: false,
-        defaultValue: { value: '' },
+        defaultValue: { value: 'asc' },
      },
    ])
    .execute();
--- a/server/src/database/typeorm-seeds/metadata/field-metadata/view.ts
+++ b/server/src/database/typeorm-seeds/metadata/field-metadata/view.ts
@ -134,7 +134,7 @@ export const seedViewFieldMetadata = async (
        icon: null,
        isNullable: false,
        isSystem: false,
-        defaultValue: undefined,
+        defaultValue: { value: '' },
      },
      {
        id: SeedViewFieldMetadataIds.Type,
--- a/server/src/database/typeorm-seeds/metadata/field-metadata/workspace-member.ts
+++ b/server/src/database/typeorm-seeds/metadata/field-metadata/workspace-member.ts
@ -3,6 +3,7 @@ import { DataSource } from 'typeorm';
 import { SeedObjectMetadataIds } from 'src/database/typeorm-seeds/metadata/object-metadata';
 import { SeedWorkspaceId } from 'src/database/seeds/metadata';
 import { FieldMetadataType } from 'src/metadata/field-metadata/field-metadata.entity';
+import { SeedPersonFieldMetadataIds } from 'src/database/typeorm-seeds/metadata/field-metadata/person';

 const fieldMetadataTableName = 'fieldMetadata';

@ -109,40 +110,23 @@ export const seedWorkspaceMemberFieldMetadata = async (
      },
      // Scalar fields
      {
-        id: SeedWorkspaceMemberFieldMetadataIds.FirstName,
+        id: SeedPersonFieldMetadataIds.Name,
        objectMetadataId: SeedObjectMetadataIds.WorkspaceMember,
        isCustom: false,
        workspaceId: SeedWorkspaceId,
        isActive: true,
-        type: FieldMetadataType.TEXT,
-        name: 'firstName',
-        label: 'First name',
+        type: FieldMetadataType.FULL_NAME,
+        name: 'name',
+        label: 'Name',
        targetColumnMap: {
-          value: 'firstName',
+          firstName: 'nameFirstName',
+          lastName: 'nameLastName',
        },
-        description: 'Workspace member first name',
+        description: 'Workspace member name',
        icon: 'IconCircleUser',
        isNullable: false,
        isSystem: false,
-        defaultValue: { value: '' },
-      },
-      {
-        id: SeedWorkspaceMemberFieldMetadataIds.LastName,
-        objectMetadataId: SeedObjectMetadataIds.WorkspaceMember,
-        isCustom: false,
-        workspaceId: SeedWorkspaceId,
-        isActive: true,
-        type: FieldMetadataType.TEXT,
-        name: 'lastName',
-        label: 'Last name',
-        targetColumnMap: {
-          value: 'lastName',
-        },
-        description: 'Workspace member last name',
-        icon: 'IconCircleUser',
-        isNullable: false,
-        isSystem: false,
-        defaultValue: { value: '' },
+        defaultValue: { firstName: '', lastName: '' },
      },
      {
        id: SeedWorkspaceMemberFieldMetadataIds.AvatarUrl,
--- a/server/src/database/typeorm-seeds/workspace/workspaceMember.ts
+++ b/server/src/database/typeorm-seeds/workspace/workspaceMember.ts
@ -23,8 +23,8 @@ export const seedWorkspaceMember = async (
    .insert()
    .into(`${schemaName}.${tableName}`, [
      'id',
-      'firstName',
-      'lastName',
+      'nameFirstName',
+      'nameLastName',
      'locale',
      'colorScheme',
      'allowImpersonation',
@ -34,8 +34,8 @@ export const seedWorkspaceMember = async (
    .values([
      {
        id: WorkspaceMemberIds.Tim,
-        firstName: 'Tim',
-        lastName: 'Apple',
+        nameFirstName: 'Tim',
+        nameLastName: 'Apple',
        locale: 'en',
        colorScheme: 'Light',
        allowImpersonation: true,
@ -43,8 +43,8 @@ export const seedWorkspaceMember = async (
      },
      {
        id: WorkspaceMemberIds.Jony,
-        firstName: 'Jony',
-        lastName: 'Ive',
+        nameFirstName: 'Jony',
+        nameLastName: 'Ive',
        locale: 'en',
        colorScheme: 'Light',
        allowImpersonation: true,
@ -52,8 +52,8 @@ export const seedWorkspaceMember = async (
      },
      {
        id: WorkspaceMemberIds.Phil,
-        firstName: 'Phil',
-        lastName: 'Shiler',
+        nameFirstName: 'Phil',
+        nameLastName: 'Shiler',
        locale: 'en',
        colorScheme: 'Light',
        allowImpersonation: true,
--- a/server/src/metadata/workspace-migration/migrations/1697618009-addCompanyTable.ts
+++ b/server/src/metadata/workspace-migration/migrations/1697618009-addCompanyTable.ts
@ -16,6 +16,7 @@ export const addCompanyTable: WorkspaceMigrationTableAction[] = [
        columnName: 'name',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'domainName',
--- a/server/src/metadata/workspace-migration/migrations/1697618011-addViewTable.ts
+++ b/server/src/metadata/workspace-migration/migrations/1697618011-addViewTable.ts
@ -16,16 +16,19 @@ export const addViewTable: WorkspaceMigrationTableAction[] = [
        columnName: 'name',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'objectMetadataId',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'type',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
    ],
  },
--- a/server/src/metadata/workspace-migration/migrations/1697618012-addViewFieldTable.ts
+++ b/server/src/metadata/workspace-migration/migrations/1697618012-addViewFieldTable.ts
@ -16,21 +16,25 @@ export const addViewFieldTable: WorkspaceMigrationTableAction[] = [
        columnName: 'fieldMetadataId',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'position',
        columnType: 'integer',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: 0,
      },
      {
        columnName: 'isVisible',
        columnType: 'boolean',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: true,
      },
      {
        columnName: 'size',
        columnType: 'integer',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: 0,
      },
      {
        columnName: 'viewId',
--- a/server/src/metadata/workspace-migration/migrations/1697618013-addViewFilterTable.ts
+++ b/server/src/metadata/workspace-migration/migrations/1697618013-addViewFilterTable.ts
@ -16,21 +16,25 @@ export const addViewFilterTable: WorkspaceMigrationTableAction[] = [
        columnName: 'fieldMetadataId',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'operand',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "'Contains'",
      },
      {
        columnName: 'value',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'displayValue',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'viewId',
--- a/server/src/metadata/workspace-migration/migrations/1697618014-addViewSortTable.ts
+++ b/server/src/metadata/workspace-migration/migrations/1697618014-addViewSortTable.ts
@ -16,11 +16,13 @@ export const addViewSortTable: WorkspaceMigrationTableAction[] = [
        columnName: 'fieldMetadataId',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'direction',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "'asc'",
      },
      {
        columnName: 'viewId',
--- a/server/src/metadata/workspace-migration/migrations/1697618018-addAttachmentTable.ts
+++ b/server/src/metadata/workspace-migration/migrations/1697618018-addAttachmentTable.ts
@ -16,16 +16,19 @@ export const addAttachmentTable: WorkspaceMigrationTableAction[] = [
        columnName: 'name',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'fullPath',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'type',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'companyId',
--- a/server/src/metadata/workspace-migration/migrations/1697618019-addCommentTable.ts
+++ b/server/src/metadata/workspace-migration/migrations/1697618019-addCommentTable.ts
@ -16,6 +16,7 @@ export const addCommentTable: WorkspaceMigrationTableAction[] = [
        columnName: 'body',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'authorId',
--- a/server/src/metadata/workspace-migration/migrations/1697618020-addFavoriteTable.ts
+++ b/server/src/metadata/workspace-migration/migrations/1697618020-addFavoriteTable.ts
@ -16,6 +16,7 @@ export const addFavoriteTable: WorkspaceMigrationTableAction[] = [
        columnName: 'position',
        columnType: 'float',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: 0,
      },
      {
        columnName: 'companyId',
--- a/server/src/metadata/workspace-migration/migrations/1697618022-addPersonTable.ts
+++ b/server/src/metadata/workspace-migration/migrations/1697618022-addPersonTable.ts
@ -16,11 +16,13 @@ export const addPersonTable: WorkspaceMigrationTableAction[] = [
        columnName: 'nameFirstName',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'nameLastName',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'email',
--- a/server/src/metadata/workspace-migration/migrations/1697618023-addPipelineStepTable.ts
+++ b/server/src/metadata/workspace-migration/migrations/1697618023-addPipelineStepTable.ts
@ -16,16 +16,19 @@ export const addPipelineStepTable: WorkspaceMigrationTableAction[] = [
        columnName: 'name',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'color',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'position',
        columnType: 'float',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: 0,
      },
    ],
  },
--- a/server/src/metadata/workspace-migration/migrations/1697618024-addWebhookTable.ts
+++ b/server/src/metadata/workspace-migration/migrations/1697618024-addWebhookTable.ts
@ -16,11 +16,13 @@ export const addWebhookTable: WorkspaceMigrationTableAction[] = [
        columnName: 'targetUrl',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'operation',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
    ],
  },
--- a/server/src/metadata/workspace-migration/migrations/1697618026-addWorspaceMemberTable.ts
+++ b/server/src/metadata/workspace-migration/migrations/1697618026-addWorspaceMemberTable.ts
@ -13,14 +13,16 @@ export const addWorkspaceMemberTable: WorkspaceMigrationTableAction[] = [
    action: 'alter',
    columns: [
      {
-        columnName: 'firstName',
+        columnName: 'nameFirstName',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
-        columnName: 'lastName',
+        columnName: 'nameLastName',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "''",
      },
      {
        columnName: 'avatarUrl',
@ -36,6 +38,7 @@ export const addWorkspaceMemberTable: WorkspaceMigrationTableAction[] = [
        columnName: 'locale',
        columnType: 'varchar',
        action: WorkspaceMigrationColumnActionType.CREATE,
+        defaultValue: "'fr'",
      },
      {
        columnName: 'allowImpersonation',
--- a/server/src/workspace/workspace-manager/standard-objects/attachment.ts
+++ b/server/src/workspace/workspace-manager/standard-objects/attachment.ts
@ -23,6 +23,7 @@ const attachmentMetadata = {
      description: 'Attachment name',
      icon: 'IconFileUpload',
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      isCustom: false,
@ -36,6 +37,7 @@ const attachmentMetadata = {
      description: 'Attachment full path',
      icon: 'IconLink',
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      isCustom: false,
@ -49,6 +51,7 @@ const attachmentMetadata = {
      description: 'Attachment type',
      icon: 'IconList',
      isNullable: false,
+      defaultValue: { value: '' },
    },
    // Relations
    {
--- a/server/src/workspace/workspace-manager/standard-objects/comment.ts
+++ b/server/src/workspace/workspace-manager/standard-objects/comment.ts
@ -23,6 +23,7 @@ const commentMetadata = {
      description: 'Comment body',
      icon: 'IconLink',
      isNullable: false,
+      defaultValue: { value: '' },
    },
    // Relations
    {
--- a/server/src/workspace/workspace-manager/standard-objects/company.ts
+++ b/server/src/workspace/workspace-manager/standard-objects/company.ts
@ -23,6 +23,7 @@ const companyMetadata = {
      description: 'The company name',
      icon: 'IconBuildingSkyscraper',
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      isCustom: false,
--- a/server/src/workspace/workspace-manager/standard-objects/favorite.ts
+++ b/server/src/workspace/workspace-manager/standard-objects/favorite.ts
@ -23,6 +23,7 @@ const favoriteMetadata = {
      description: 'Favorite position',
      icon: 'IconList',
      isNullable: false,
+      defaultValue: { value: 0 },
    },
    // Relations
    {
--- a/server/src/workspace/workspace-manager/standard-objects/pipeline-step.ts
+++ b/server/src/workspace/workspace-manager/standard-objects/pipeline-step.ts
@ -23,6 +23,7 @@ const pipelineStepMetadata = {
      description: 'Pipeline Step name',
      icon: 'IconCurrencyDollar',
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      isCustom: false,
@ -36,6 +37,7 @@ const pipelineStepMetadata = {
      description: 'Pipeline Step color',
      icon: 'IconColorSwatch',
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      isCustom: false,
@ -49,6 +51,7 @@ const pipelineStepMetadata = {
      description: 'Pipeline Step position',
      icon: 'IconHierarchy2',
      isNullable: false,
+      defaultValue: { value: 0 },
    },
    // Relations
    {
--- a/server/src/workspace/workspace-manager/standard-objects/standard-object-metadata.ts
+++ b/server/src/workspace/workspace-manager/standard-objects/standard-object-metadata.ts
@ -50,6 +50,7 @@ export const basicFieldsMetadata: Partial<FieldMetadataEntity>[] = [
    // isSystem: true,
    isCustom: false,
    isActive: true,
+    defaultValue: { type: 'uuid' },
  },
  {
    name: 'createdAt',
@ -62,6 +63,7 @@ export const basicFieldsMetadata: Partial<FieldMetadataEntity>[] = [
    isNullable: true,
    isCustom: false,
    isActive: true,
+    defaultValue: { type: 'now' },
  },
  {
    name: 'updatedAt',
@ -74,5 +76,6 @@ export const basicFieldsMetadata: Partial<FieldMetadataEntity>[] = [
    isNullable: true,
    isCustom: false,
    isActive: true,
+    defaultValue: { type: 'now' },
  },
 ];
--- a/server/src/workspace/workspace-manager/standard-objects/view-field.ts
+++ b/server/src/workspace/workspace-manager/standard-objects/view-field.ts
@ -23,6 +23,7 @@ const viewFieldMetadata = {
      description: 'View Field target field',
      icon: 'IconTag',
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      isCustom: false,
@ -36,6 +37,7 @@ const viewFieldMetadata = {
      description: 'View Field visibility',
      icon: 'IconEye',
      isNullable: false,
+      defaultValue: { value: true },
    },
    {
      isCustom: false,
@ -49,6 +51,7 @@ const viewFieldMetadata = {
      description: 'View Field size',
      icon: 'IconEye',
      isNullable: false,
+      defaultValue: { value: 0 },
    },
    {
      isCustom: false,
@ -62,6 +65,7 @@ const viewFieldMetadata = {
      description: 'View Field position',
      icon: 'IconList',
      isNullable: false,
+      defaultValue: { value: 0 },
    },
    {
      isCustom: false,
--- a/server/src/workspace/workspace-manager/standard-objects/view-filter.ts
+++ b/server/src/workspace/workspace-manager/standard-objects/view-filter.ts
@ -23,6 +23,7 @@ const viewFilterMetadata = {
      description: 'View Filter target field',
      icon: null,
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      isCustom: false,
@ -36,6 +37,7 @@ const viewFilterMetadata = {
      description: 'View Filter operand',
      icon: null,
      isNullable: false,
+      defaultValue: { value: 'Contains' },
    },
    {
      isCustom: false,
@ -49,6 +51,7 @@ const viewFilterMetadata = {
      description: 'View Filter value',
      icon: null,
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      isCustom: false,
@ -62,6 +65,7 @@ const viewFilterMetadata = {
      description: 'View Filter Display Value',
      icon: null,
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      isCustom: false,
--- a/server/src/workspace/workspace-manager/standard-objects/view-sort.ts
+++ b/server/src/workspace/workspace-manager/standard-objects/view-sort.ts
@ -23,6 +23,7 @@ const viewSortMetadata = {
      description: 'View Sort target field',
      icon: null,
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      isCustom: false,
@ -36,6 +37,7 @@ const viewSortMetadata = {
      description: 'View Sort direction',
      icon: null,
      isNullable: false,
+      defaultValue: { value: 'asc' },
    },
    {
      isCustom: false,
--- a/server/src/workspace/workspace-manager/standard-objects/view.ts
+++ b/server/src/workspace/workspace-manager/standard-objects/view.ts
@ -21,6 +21,7 @@ const viewMetadata = {
      description: 'View name',
      icon: null,
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      type: FieldMetadataType.TEXT,
@ -32,6 +33,7 @@ const viewMetadata = {
      description: 'View target object',
      icon: null,
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      type: FieldMetadataType.TEXT,
@ -43,6 +45,7 @@ const viewMetadata = {
      description: 'View type',
      icon: null,
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      isCustom: false,
--- a/server/src/workspace/workspace-manager/standard-objects/webhook.ts
+++ b/server/src/workspace/workspace-manager/standard-objects/webhook.ts
@ -23,6 +23,7 @@ const webhookMetadata = {
      description: 'Webhook target url',
      icon: 'IconLink',
      isNullable: false,
+      defaultValue: { value: '' },
    },
    {
      isCustom: false,
@ -36,6 +37,7 @@ const webhookMetadata = {
      description: 'Webhook operation',
      icon: 'IconCheckbox',
      isNullable: false,
+      defaultValue: { value: '' },
    },
  ],
 };
--- a/server/src/workspace/workspace-manager/standard-objects/workspace-member.ts
+++ b/server/src/workspace/workspace-manager/standard-objects/workspace-member.ts
@ -27,28 +27,17 @@ const workspaceMemberMetadata = {
    {
      isCustom: false,
      isActive: true,
-      type: FieldMetadataType.TEXT,
-      name: 'lastName',
-      label: 'Last name',
+      type: FieldMetadataType.FULL_NAME,
+      name: 'name',
+      label: 'Name',
      targetColumnMap: {
-        value: 'lastName',
+        firstName: 'nameFirstName',
+        lastName: 'nameLastName',
      },
-      description: 'Workspace member last name',
+      description: 'Workspace member name',
      icon: 'IconCircleUser',
      isNullable: false,
-    },
-    {
-      isCustom: false,
-      isActive: true,
-      type: FieldMetadataType.UUID,
-      name: 'userId',
-      label: 'User Id',
-      targetColumnMap: {
-        value: 'userId',
-      },
-      description: 'Associated User Id',
-      icon: 'IconCircleUsers',
-      isNullable: false,
+      defaultValue: { firstName: '', lastName: '' },
    },
    {
      isCustom: false,
@ -88,6 +77,7 @@ const workspaceMemberMetadata = {
      description: 'Preferred language',
      icon: 'IconLanguage',
      isNullable: false,
+      defaultValue: { value: 'fr' },
    },
    {
      isCustom: false,