Félix Malfait
152902d1be
New useNavigateApp ( #9729 )
...
Todo :
- replace all instances of useNavigate(
- remove getSettingsPagePath
- add eslint rule to enfore usage of useNavigateApp instead of
useNavigate
2025-01-18 13:58:12 +01:00
Anne Deepa Prasanna and Félix Malfait
f44b31573a
Set up localization with feature flag control ( #9649 )
...
Refers #8128
Changes Introduced:
- Added i18n configuration.
- Added a feature flag for localization.
- Enabled language switching based on the flag.
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2025-01-16 21:00:56 +01:00
Etienne and etiennejouan
26058f3e25
Update ChooseYourPlan page with new trial period options ( #9628 )
...
### Context
- Update /plan-required page to let users get free trial without credit
card plan
- Update usePageChangeEffectNavigateLocation to redirect paused and
canceled subscription (suspended workspace) to /settings/billing page
### To do
- [x] Update usePageChangeEffectNavigateLocation test
- [x] Update ChooseYourPlan sb test
closes #9520
---------
Co-authored-by: etiennejouan <jouan.etienne@gmail.com >
2025-01-16 11:10:36 +01:00
Raphaël Bosi
ff93fd3c74
190 display ctrl instead of for windows users ( #9617 )
...
Closes https://github.com/twentyhq/core-team-issues/issues/190
<img width="226" alt="Capture d’écran 2025-01-15 à 12 07 12"
src="https://github.com/user-attachments/assets/b9a13746-2629-477a-9795-cda03c63f8f6 "
/>
To test, update the user agent in your browser dev tools:
<img width="459" alt="Capture d’écran 2025-01-15 à 12 14 29"
src="https://github.com/user-attachments/assets/4371d5fc-fd3c-403d-beaa-7ba58019d3c9 "
/>
2025-01-15 12:53:18 +00:00
Supriyo and Marie Stoppa
f151963e66
fixs #9456 : Workspace switcher font weight ( #9591 )
...
Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu >
2025-01-14 11:52:19 +00:00
nitin
ae68a4b8d9
Navigation drawer sibling gap fix ( #9472 )
...
fixes
https://discord.com/channels/1130383047699738754/1326560179113955328/1326560179113955328
2025-01-09 10:49:43 +01:00
nitin and Lucas Bordeau
bec7911d59
Navigation drawer scroll padding fix ( #9141 )
...
closes https://github.com/twentyhq/twenty/issues/9026
fixes #9312
https://github.com/user-attachments/assets/3d7df3ec-8a5e-4308-8993-82c715edc683
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2025-01-08 14:03:47 +00:00
nitin
4f7fa7adcd
Minor active navigation drawer item label font color fix ( #9356 )
...
fixes
https://discord.com/channels/1130383047699738754/1324667162379685972/1324667162379685972
2025-01-08 02:33:20 +05:30
Marie
7d7955fc65
Move capitalize into twenty-shared ( #9414 )
...
capitalize had been moved into twenty-shared. Let's remove the
duplicates in server and front !
2025-01-07 14:25:29 +00:00
2c7f40ab1d
Fix NavigationDrawer story ( #9235 )
...
Closes https://github.com/twentyhq/twenty/issues/7492
## Description
This PR will fix NavigationDrawer story.
## Testing
<img width="1407" alt="スクリーンショット 2024-12-25 23 27 25"
src="https://github.com/user-attachments/assets/d9ee4363-f2b2-408f-b2b8-c4dd92cfd66b "
/>
<img width="1326" alt="スクリーンショット 2024-12-26 0 28 47"
src="https://github.com/user-attachments/assets/b21fbe02-9d56-4b9b-8631-ee4530e5a5d1 "
/>
---------
Co-authored-by: Takuya Kurimoto <takuya004869@gmail.com >
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-12-31 14:00:45 +00:00
Thomas Trompette and ehconitin
5bd685ef2a
Fix Navigation drawer design for object path ( #9290 )
...
Navigation drawer design is broken for object path, we always see
elipsis. Comes from the fact we only use padding 2px on right while
using 4px on the left.
<img width="242" alt="Capture d’écran 2024-12-31 à 08 27 11"
src="https://github.com/user-attachments/assets/bbc673f3-9c61-4df9-999e-d4a2d93276a9 "
/>
Using 2px padding only makes sense when there is a right element, to
match figma.
<img width="242" alt="Capture d’écran 2024-12-31 à 08 29 07"
src="https://github.com/user-attachments/assets/db5fe19c-5074-4f5c-a1b5-af183c0eb745 "
/>
Adding a condition to using 4px padding if no right element.
<img width="224" alt="Capture d’écran 2024-12-31 à 08 22 53"
src="https://github.com/user-attachments/assets/9909fd10-75a6-43ee-ae3d-c7124e5421b9 "
/>
Co-authored-by: ehconitin <nitinkoche03@gmail.com >
2024-12-31 09:24:06 +01:00
Thomas Trompette
f63b0a235a
Make record name editable on show page ( #9172 )
...
When fields are not displayed in show page, title should be editable
https://github.com/user-attachments/assets/049c2998-6944-46c7-9e9e-f6d29da06c6c
2024-12-26 10:59:17 +01:00
nitin
b3c1f62a5f
collapsed navigationDrawerItem width fix ( #9211 )
...
Before:
<img width="81" alt="Screenshot 2024-12-23 at 9 25 25 PM"
src="https://github.com/user-attachments/assets/d4c07ed5-0953-422f-aabf-fa2ca10ba7e5 "
/>
After:
<img width="76" alt="Screenshot 2024-12-23 at 9 25 11 PM"
src="https://github.com/user-attachments/assets/1ea6d64e-8c1f-4d0c-9b34-f8dceae9538d "
/>
2024-12-23 17:04:29 +01:00
nitin and Weiko
061c92069f
Fix position calculations -- favorites ( #9202 )
...
Co-authored-by: Weiko <corentin@twenty.com >
2024-12-23 14:45:01 +00:00
Guillim
c992be1694
Workspace logo is not visible ( #9174 )
...
Fixing "Workspace logo is not visible in the navbar" report issue from
@Weiko
2024-12-20 18:15:02 +01:00
nitin
2e216e7a73
Icon alignment in NavigationDrawerItems ( #9164 )
...
Icons are not aligned to the labels
before:
<img width="387" alt="Screenshot 2024-12-20 at 4 09 01 PM"
src="https://github.com/user-attachments/assets/c115abcd-9779-4597-b40e-6ceceeaa13b9 "
/>
after:
<img width="387" alt="Screenshot 2024-12-20 at 4 08 36 PM"
src="https://github.com/user-attachments/assets/a0535030-a810-4023-b677-8380b833f712 "
/>
2024-12-20 11:53:21 +01:00
784bc78ed0
add: objectName in fav folder ( #8785 )
...
Closes : #8549
It was quite complex to get this right. So, I went through Notion's
website to see how they implemented it.
Instead of using `display: none` or having a space reserved for the
Icon, I used clip-path & opacity trick to achieve the desired behaviour.
This maintains accessibility and helps in label or ObjectName to take
the full space.
Also, truncation now works for label & objectName as a whole instead of
separately, as seen in my previous PR.
**Caveats**
The only problem that now remains is not having
`NavigationDrawerAnimatedCollapseWrapper`. Having it on top of any text
or div won't let the flex or truncation property work.
[Screencast from 2024-11-28
13-37-31.webm](https://github.com/user-attachments/assets/29255cd2-3f15-4b1d-b1e1-c041c70052e5 )
---------
Co-authored-by: ehconitin <nitinkoche03@gmail.com >
Co-authored-by: martmull <martmull@hotmail.fr >
2024-12-19 11:51:03 +01:00
Charles Bochet
71254bfca0
Fix workspace logo ( #9129 )
...
Follow up on:
https://github.com/twentyhq/twenty/issues/9042#issuecomment-2550886611
2024-12-18 18:09:52 +01:00
fb8d193238
Fix: Replace styled logo with Avatar component for workspace logo in NavigationDrawerHeader ( #9093 )
...
This PR addresses issue #9042
- Replaced the styled logo with the `Avatar` component.
- `Avatar` now handles the case when no `logo` is uploaded by using the
workspace name's first character as the `placeholder`.
- This ensures a consistent fallback when the `logo` is undefined.
---------
Co-authored-by: guillim <guigloo@msn.com >
Co-authored-by: Félix Malfait <felix@twenty.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-12-17 20:42:06 +01:00
nitin and Charles Bochet
c63842925f
Favorites Folders Fast Followups ( #8920 )
...
Fixes :
<img width="716" alt="Screenshot 2024-12-06 at 3 45 41 PM"
src="https://github.com/user-attachments/assets/61fdf355-0d0a-4ed7-befa-ada23341a58f ">
Fixes: Reduce menu width to 160px and it should appear below three dots
<img width="394" alt="Screenshot 2024-12-06 at 3 46 49 PM"
src="https://github.com/user-attachments/assets/b1266f83-9b6f-445b-9409-d7f691776bd0 ">
Fixes: The right margin should be 2px
<img width="1134" alt="Screenshot 2024-12-06 at 3 47 45 PM"
src="https://github.com/user-attachments/assets/b6dd857c-6575-418d-8e32-64cd4e5d4e85 ">
Fixes:
Requirement: Clicking the heart Icon should put the record as favorite.
It shouldn't open the menu on first click. It should only on second
click, when the record is already a favorite.
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-12-17 12:15:36 +01:00
08a9db2df6
Add Twenty Shared & Fix profile image rendering ( #8841 )
...
PR Summary:
1. Added `Twenty Shared` Package to centralize utilitiies as mentioned
in #8942
2. Optimization of `getImageAbsoluteURI.ts` to handle edge cases
---------
Co-authored-by: Antoine Moreaux <moreaux.antoine@gmail.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-12-17 09:24:21 +01:00
nitin
257834ea71
In navigation drawer, cursor should not be drag on hover and some enhancements ( #8975 )
...
as per the title- on hover, the draggable items had a grab cursor.
Couldn't change it to a pointer, because then onClick would have a weird
behavior of grab which causes lag onClick.
2024-12-13 14:37:46 +01:00
Charles Bochet
99f53a5030
Fix broken image urls in Settings > Profile and Invite To Workspace Email ( #8942 )
...
Fixes #8601
We had 3 implementations of getImageAbsoluteURI: in twenty-front, in
twenty-ui and in twenty-emails. I was able to remove the one in
twenty-front but I could not remove it from twenty-emails as this is a
standalone for now. The vision is to introduce shared utils in a
twenty-shared package
2024-12-07 14:57:32 +01:00
Lucas Bordeau
a9cb20f317
Refactor and fixes dropdown bugs ( #8807 )
...
Fixes https://github.com/twentyhq/twenty/issues/8788
Fixes https://github.com/twentyhq/twenty/issues/8793
Fixes https://github.com/twentyhq/twenty/issues/8791
Fixes https://github.com/twentyhq/twenty/issues/8890
Fixes https://github.com/twentyhq/twenty/issues/8893
- [x] Also :
Icon buttons under dropdown are visible without blur :
- [x] Also :
<img width="237" alt="image"
src="https://github.com/user-attachments/assets/e4c70936-beff-4481-89cb-0a32a36e0ee2 ">
- [x] Also :
<img width="335" alt="image"
src="https://github.com/user-attachments/assets/5be60395-6baf-49eb-8d40-197add049e20 ">
- [x] Also :
<img width="287" alt="image"
src="https://github.com/user-attachments/assets/a317561f-7986-4d70-a1c0-deee4f4e268a ">
- Button create new without padding
- Container is expanding
- [x] Also :
<img width="303" alt="image"
src="https://github.com/user-attachments/assets/09f8a27f-91db-4191-acdc-aaaeedaf6da5 ">
- [x] Also :
<img width="133" alt="image"
src="https://github.com/user-attachments/assets/fe17b32e-f7a4-46c4-8040-239eaf8198e8 ">
Font is cut at bottom ?
- [x] Also :
<img width="385" alt="image"
src="https://github.com/user-attachments/assets/7bab2092-2936-4112-a2ee-d32d6737e304 ">
The component should flip and not resize in this situation
- [x] Also :
<img width="244" alt="image"
src="https://github.com/user-attachments/assets/5384f49a-71f9-4638-a60c-158cc8c83f81 ">
- [x] Also :
2024-12-06 14:27:48 +00:00
Antoine Moreaux
ab22fd560a
fix(): Add default name to workspace in MultiWorkspaceDropdownButton ( #8924 )
...
Fix #8923
2024-12-06 12:23:02 +01:00
Antoine Moreaux
081ecbcfaf
review(front): refacto url-manager ( #8861 )
...
Replace https://github.com/twentyhq/twenty/pull/8855
2024-12-05 11:47:51 +01:00
Antoine Moreaux
7943141d03
feat(*): allow to select auth providers + add multiworkspace with subdomain management ( #8656 )
...
## Summary
Add support for multi-workspace feature and adjust configurations and
states accordingly.
- Introduced new state isMultiWorkspaceEnabledState.
- Updated ClientConfigProviderEffect component to handle
multi-workspace.
- Modified GraphQL schema and queries to include multi-workspace related
configurations.
- Adjusted server environment variables and their respective
documentation to support multi-workspace toggle.
- Updated server-side logic to handle new multi-workspace configurations
and conditions.
2024-12-03 19:06:28 +01:00
nitin and Félix Malfait
e96ad9a1f2
Admin panel init ( #8742 )
...
WIP
Related issues -
#7090
#8547
Master issue -
#4499
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-28 13:43:11 +01:00
Harsh Singh
49526937fa
fix: navigation drawer clip while making folder in favorites ( #8619 )
2024-11-25 19:49:22 +00:00
0125d58ba8
Favorite folders ( #7998 )
...
closes - #5755
---------
Co-authored-by: martmull <martmull@hotmail.fr >
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-11-18 15:22:19 +01:00
Khuddite
ade1c57ff4
Fix remove redundant onClick event in favor of Link component ( #8540 )
...
Fixes : #8531
1. Summary
There is `onClick` event handler defined for `NavigationDrawerItem`
component, and inside the handler, if `to` is not empty, we trigger
another navigation when it's already handled by `Link` component from
`react-router-dom`
2. Solution
Removed extra navigation logic from `NavigationDrawerItem`'s `onClick`
handler
3. Screen Recording
https://github.com/user-attachments/assets/cfefdd51-1663-4d96-acd2-57783ae9877f
2024-11-18 09:41:14 +01:00
6264d509bd
Migrate to twenty-ui - navigation/menu-item ( #8213 )
...
This PR was created by [GitStart](https://gitstart.com/ ) to address the
requirements from this ticket:
[TWNTY-7536](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-7536 ).
---
### Description
Migrate all menu items components to twenty ui and update imports.
```typescript
MenuItem
MenuItemAvata
MenuItemCommand
MenuItemCommandHotKeys
MenuItemDraggable
MenuItemMultiSelect
MenuItemMultiSelectAvatar
MenuItemMultiSelectTag
MenuItemNavigate
MenuItemSelect
MenuItemSelectAvatar
MenuItemSelectColor
MenuItemSelectTag
MenuItemSuggestion
MenuItemToggle
```
\
Also migrate all other dependent components and utilities like
`Checkbox` & `Toggle`\
\
Fixes twentyhq/private-issues#82
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com >
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-11-07 16:51:39 +00:00
Charles Bochet
88ba057b2c
Fix 0.32 bis ( #8346 )
...
Various UI fixes according to discussions with Design team
2024-11-05 18:14:44 +01:00
Marie
7dfde04957
Fix advanced settings display ( #8196 )
...
In [this PR (fix navigation
overflow)](https://github.com/twentyhq/twenty/pull/7795 ) we introduced a
regression, hidding the left-side animation with advanced settings:
<img width="285" alt="Capture d’écran 2024-10-30 à 12 56 22"
src="https://github.com/user-attachments/assets/46d7b1e5-4759-42e9-9bcb-aaa0fedfe542 ">
<img width="274" alt="Capture d’écran 2024-10-30 à 12 56 31"
src="https://github.com/user-attachments/assets/d3c3d337-f6fc-4509-a920-4c2c7506f061 ">
2024-10-30 16:18:44 +00:00
Reese is on Codeberg and martmull
a725245c2f
Add padding to navigation header ( #8050 )
...
This PR adds padding to the header to align the logo with other icons on
the sidebar.
## Before
## After
---------
Co-authored-by: martmull <martmull@hotmail.fr >
2024-10-29 07:56:16 +00:00
b09ecfbb8c
Migrate to twenty-ui - display ( #8004 )
...
This PR was created by [GitStart](https://gitstart.com/ ) to address the
requirements from this ticket:
[TWNTY-6871](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-6871 ).
---
### Description
Migrate:
- Info display component
- Status display component
- SeparatorLineText display component
### Demo
###### SeparatorLineText In Storybook
Info Component on Storybook
Status Component on Storybook
###### Fixes twentyhq/private-issues#95
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-10-24 17:50:14 +02:00
0a28c15747
Migrate to twenty-ui - input/button ( #7994 )
...
This PR was created by [GitStart](https://gitstart.com/ ) to address the
requirements from this ticket:
[TWNTY-7529](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-7529 ).
---
### Description
- Migrated all button components to `twenty-ui` \
\
`Button`\
`ButtonGroup`\
`ColorPickerButton`\
`FloatingButton`\
`FloatingButtonGroup`\
`FloatingIconButton`\
`FloatingIconButtonGroup`\
`IconButton`\
`IconButtonGroup`\
`LightButton`\
`LightIconButton`\
`LightIconButtonGroup`\
`MainButton`\
\
Fixes twentyhq/private-issues#89
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-10-24 13:20:02 +02:00
430644448a
Migrate to twenty-ui - navigation/link ( #7837 )
...
This PR was created by [GitStart](https://gitstart.com/ ) to address the
requirements from this ticket:
[TWNTY-7535](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-7535 ).
---
### Description.
Migrate link components to `twenty-ui` \
\
Fixes #7535
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-10-22 17:36:26 +02:00
0f0a7966b1
feat(sso): allow to use OIDC and SAML ( #7246 )
...
## What it does
### Backend
- [x] Add a mutation to create OIDC and SAML configuration
- [x] Add a mutation to delete an SSO config
- [x] Add a feature flag to toggle SSO
- [x] Add a mutation to activate/deactivate an SSO config
- [x] Add a mutation to delete an SSO config
- [x] Add strategy to use OIDC or SAML
- [ ] Improve error management
### Frontend
- [x] Add section "security" in settings
- [x] Add page to list SSO configurations
- [x] Add page and forms to create OIDC or SAML configuration
- [x] Add field to "connect with SSO" in the signin/signup process
- [x] Trigger auth when a user switch to a workspace with SSO enable
- [x] Add an option on the security page to activate/deactivate the
global invitation link
- [ ] Add new Icons for SSO Identity Providers (okta, Auth0, Azure,
Microsoft)
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-10-21 20:07:08 +02:00
DivyanshuLohani and Devessier
1a0b387282
Add the role=button to search ( #7594 )
...
In this PR:
- Let the `<NavigationDrawerItem />` component render a `<button>` by
default instead of a `<div>`
- Replace `<div>` by `<span>` inside the `<NavigationDrawerItem />` as
`<button>` and `<a>` HTML elements only accept [_phrasing
content_](https://developer.mozilla.org/en-US/docs/Web/HTML/Content_categories#phrasing_content ).
- Fix layout issue: the keyboard icon wasn't put on the right of the
button, I put it back
Fixes #7575
---------
Co-authored-by: Devessier <baptiste@devessier.fr >
2024-10-21 18:21:08 +02:00
Hitarth Sheth and Lucas Bordeau
f6c094a56f
[FIX] fix navigation overflow ( #7795 )
...
FIX #7733
Fixes the overflow and responsive problem on large and small devices.
The 'Workspace' title is fixed and only links under it are scrolled when
overflown.
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-10-18 00:49:42 +02:00
nitin
fad04144a3
minor fix - collapse button hover and dropdown button width ( #7748 )
...
follow up - #7414
2024-10-16 15:13:26 +02:00
nitin
a9deede9ba
feat - Compact sidebar ( #7414 )
2024-10-15 14:02:28 +02:00
Harshit Singh and Lucas Bordeau
9277cb7729
fix: Settings Navigation drawer crops elements ( #7557 )
...
Closes #7550
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-10-10 17:22:07 +02:00
Thomas Trompette
10fa6e1a6f
Add margin bottom to all navigation drawer items ( #7544 )
...
<img width="259" alt="Capture d’écran 2024-10-09 à 15 43 39"
src="https://github.com/user-attachments/assets/4ddf2ca6-73a6-4d18-9ec6-83b30d66514f ">
<img width="259" alt="Capture d’écran 2024-10-09 à 15 43 49"
src="https://github.com/user-attachments/assets/a2c82fba-954a-4104-9a83-427d11644567 ">
2024-10-09 16:20:24 +02:00
Thomas Trompette
cbdd09b00e
Fix advanced settings animation ( #7497 )
...
As title
2024-10-08 17:14:50 +02:00
Thomas Trompette
66ec70f776
Fix hover advanced settings ( #7488 )
...
<img width="264" alt="Capture d’écran 2024-10-08 à 12 12 59"
src="https://github.com/user-attachments/assets/a01621ef-d7e8-44d1-b301-9579ab632a60 ">
2024-10-08 13:36:20 +02:00
Thomas Trompette
fbb5b3dfd4
Fix settings navigation advanced design ( #7472 )
...
This PR moved the settings navigation to the left and bottom
https://github.com/twentyhq/twenty/pull/7130
Updating the logic to:
-remove logic that move the existing
-add the setting icon to absolute
<img width="264" alt="Capture d’écran 2024-10-07 à 18 04 05"
src="https://github.com/user-attachments/assets/b848a5dd-50e9-48c2-bb50-1dcffa9481ac ">
<img width="264" alt="Capture d’écran 2024-10-07 à 18 04 11"
src="https://github.com/user-attachments/assets/3812929c-dce0-410b-8caa-3ea1210af958 ">
2024-10-07 18:19:00 +02:00
8afa504b65
Add Skeleton loading for side panel ( #7394 )
...
This PR was created by [GitStart](https://gitstart.com/ ) to address the
requirements from this ticket:
[TWNTY-7112](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-7112 ).
---
### Description
- To test you can use `await new Promise(r => setTimeout(r, 5000));`
line 74 of \`openCreateActivityDrawer.ts\`
- We added a recoil state to define the loading status
- Design points to note:
1 - We did not change the chip component styles because would be
unrelated to the issue can you confirm if you still need this change?
2- In Figma, the loading state shows the Chip rendering an initial name
before showing the loaded name, currently, we are rendering the correct
name while loading, the change that makes this possible is below
if we set it as null, the initial name would appear, but also the
previous data in the state would affect the UI, passing the
`activityObjectNameSingular` data allows us to clear the previous data,
and make the Chip instantly updated, let us know if this behavior is
fine, or if you still want an initial name to be rendered while is
loading.
3 - Currently, the loading state of the tabs does not affect the
selected tab (auto-defined by the component) should we change this logic
for all Tabs used in the app, or make this behavior optional by using
props?
### Demo
<https://www.loom.com/share/590df738a8ec41e6b64232bde237c01f?sid=7f8f4e40-ec82-4282-a43d-452a1cf27f4a >
### Refs
#7112
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com >
Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu >
2024-10-04 11:41:05 +02:00
23001ac17d
Settings Advanced Mode ( #7130 )
...
### Description
- We implemented the Advanced Mode state and used this on a section of
the settings sidebar
- in DefaultLayout.tsx, was updated because of the 64 + 16(container
size of IconTool + the margins)
### <https://jam.dev/c/29bcec70-0b7f-4afa-98e6-9755657cf09d >
### Refs
#6147
Fixes #6147
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com >
2024-10-02 17:04:07 +02:00
Félix Malfait
