twenty

5,517 Commits 1 Branch 0 Tags

2 Commits

Author	SHA1	Message	Date
khudditeandFélix Malfait	545cfbd83e	Update documentation padding on mobile devices (#8318 ) close #8086 - Technical explanation of the issue The mobile documentation pages have a fixed width of `340px`, regardless of the device. And they are centered horizontally, so the horizontal padding is determined automatically. - Explanation of the fix I've updated the styling of those pages to use fixed padding `32px` instead and let it determine the width (`deviceWidth - 64px`). - Screenshots ![CleanShot 2024-11-04 at 15 01 59](https://github.com/user-attachments/assets/d2ecf215-cbee-4ea0-b627-53ac756095bc) ![CleanShot 2024-11-04 at 15 02 23](https://github.com/user-attachments/assets/bb03854f-17ee-43dc-bba2-feeddc6a2750) --------- Co-authored-by: Félix Malfait <felix@twenty.com>	2024-11-07 08:50:20 +01:00
khuddite	5a293b8d60	Update menu title font size based on whether or not it's clickable (#8354 ) Fixes #8350 1. Summary https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=36424-125120&node-type=instance&t=psxuagFLo1Cu26Vz-0 Based on Figma, the menu header should have `base/medium` instead of `small/medium` when it's not clickable or dropdown. However, for dropdowns, we should keep it as `small/medium`. Menu items should stay as `base/regular`. 2. Solution Utilized `onClick` prop to decide the font size of the menu header. That way, Dropdowns stay as `base/small` while non-clickable headers are updated to `base/medium` 3. Screenshots *please check out font size and weight for each case* header: ![CleanShot 2024-11-05 at 17 45 23](https://github.com/user-attachments/assets/29bd6737-7470-452b-8483-a3adc9cd4db7) menu item: ![CleanShot 2024-11-05 at 17 46 46](https://github.com/user-attachments/assets/4664156a-ad81-4437-ba71-51f88813dd88) dropdown: ![CleanShot 2024-11-05 at 17 47 38](https://github.com/user-attachments/assets/c109f4cc-3a16-4c8a-9f4b-861138cc825a)	2024-11-06 14:08:29 +01:00

Author

SHA1

Message

Date

khudditeandFélix Malfait

545cfbd83e

Update documentation padding on mobile devices (#8318 )

close #8086 

- Technical explanation of the issue
The mobile documentation pages have a fixed width of `340px`, regardless
of the device. And they are centered horizontally, so the horizontal
padding is determined automatically.

- Explanation of the fix
I've updated the styling of those pages to use fixed padding `32px`
instead and let it determine the width (`deviceWidth - 64px`).
    
- Screenshots
    
![CleanShot 2024-11-04 at 15 01
59](https://github.com/user-attachments/assets/d2ecf215-cbee-4ea0-b627-53ac756095bc)
![CleanShot 2024-11-04 at 15 02
23](https://github.com/user-attachments/assets/bb03854f-17ee-43dc-bba2-feeddc6a2750)

---------

Co-authored-by: Félix Malfait <felix@twenty.com>

2024-11-07 08:50:20 +01:00

khuddite

5a293b8d60

Update menu title font size based on whether or not it's clickable (#8354 )

Fixes #8350 

1. Summary

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=36424-125120&node-type=instance&t=psxuagFLo1Cu26Vz-0

Based on Figma, the menu header should have `base/medium` instead of
`small/medium` when it's not clickable or dropdown. However, for
dropdowns, we should keep it as `small/medium`. Menu items should stay
as `base/regular`.

2. Solution
Utilized `onClick` prop to decide the font size of the menu header. That
way, Dropdowns stay as `base/small` while non-clickable headers are
updated to `base/medium`

3. Screenshots 
***please check out font size and weight for each case***

header: ![CleanShot 2024-11-05 at 17 45
23](https://github.com/user-attachments/assets/29bd6737-7470-452b-8483-a3adc9cd4db7)

menu item: ![CleanShot 2024-11-05 at 17 46
46](https://github.com/user-attachments/assets/4664156a-ad81-4437-ba71-51f88813dd88)

dropdown: ![CleanShot 2024-11-05 at 17 47
38](https://github.com/user-attachments/assets/c109f4cc-3a16-4c8a-9f4b-861138cc825a)

2024-11-06 14:08:29 +01:00