e3b327de8e
Add missing Icons ( #8562 )
...
## Before
## After
2024-11-18 16:22:17 +01:00
fb0221b4c1
feat: default record group table ( #8397 )
...
This PR is preparing states to we'll be able to handle view groups
correctly with table data.
RowIds are now stores in 2 component states, one storing ids by view
group and another storing all the rowIds.
We're doing that because some other state like focus, or select must not
be scoped by view group id.
2024-11-18 15:36:40 +01:00
0125d58ba8
Favorite folders ( #7998 )
...
closes - #5755
---------
Co-authored-by: martmull <martmull@hotmail.fr >
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-11-18 15:22:19 +01:00
5115022355
fix: Dropdown Overlapping Sidebar on Column Header Click in Horizontal Table When Scrolling ( #8287 )
...
fixes : #8272
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-11-18 15:19:04 +01:00
d8626b1304
Fix 'Error in devtools while checking fields of object' ( #8554 )
...
Fixes https://github.com/twentyhq/twenty/issues/8298
---------
Co-authored-by: Devessier <baptiste@devessier.fr >
2024-11-18 14:59:50 +01:00
a0200e6d91
Fix workspace favorites in storybook ( #8519 )
...
- create mock page when user not logged in
- add mocks when user logged in
Reset password story
<img width="1073" alt="Capture d’écran 2024-11-15 à 16 49 31"
src="https://github.com/user-attachments/assets/5d70d587-8094-47ad-8029-d8c729bd298d ">
Record Index page story
<img width="1073" alt="Capture d’écran 2024-11-15 à 16 49 58"
src="https://github.com/user-attachments/assets/421772a9-62ee-4563-b492-5158db31fb9b ">
Reset password page
<img width="1031" alt="Capture d’écran 2024-11-15 à 16 50 18"
src="https://github.com/user-attachments/assets/2d1cb119-5e34-49d0-9cfa-2b856a96f39c ">
2024-11-18 12:08:05 +01:00
2f5dc26545
Settings Option Card component ( #8456 )
...
fixes - #8195
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-11-18 09:22:33 +00:00
ade1c57ff4
Fix remove redundant onClick event in favor of Link component ( #8540 )
...
Fixes : #8531
1. Summary
There is `onClick` event handler defined for `NavigationDrawerItem`
component, and inside the handler, if `to` is not empty, we trigger
another navigation when it's already handled by `Link` component from
`react-router-dom`
2. Solution
Removed extra navigation logic from `NavigationDrawerItem`'s `onClick`
handler
3. Screen Recording
https://github.com/user-attachments/assets/cfefdd51-1663-4d96-acd2-57783ae9877f
2024-11-18 09:41:14 +01:00
ef5cc80440
Enable array filtering ( #8538 )
...
- Set array filtering always enabled
- Rename `IS_ARRAY_AND_JSON_FILTER_ENABLED ` TO
`IS_JSON_FILTER_ENABLED`.
2024-11-18 09:38:46 +01:00
9134ed8ce4
fix: prevent non-boolean 'active' prop from being forwarded to DOM ( #8534 )
...
Fixes : #8533
2024-11-17 20:11:13 +01:00
badebc513f
Fix multi select filtering ( #5358 ) ( #8452 )
...
Allow filtering by multi-select fields.
<img width="1053" alt="Screenshot 2024-11-11 at 11 54 45"
src="https://github.com/user-attachments/assets/a79b2251-94e3-48f8-abda-e808103a6c39 ">
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-17 15:27:38 +01:00
8c33e4cdae
fix: Checkbox column width should be fixed ( #8489 )
...
## Description
- This PR adds the functionality of fixed column width across all boards
- This PR fixes the issue
#8463
#8331
<img width="1167" alt="Screenshot 2024-11-14 at 12 19 02 PM"
src="https://github.com/user-attachments/assets/7c2b1016-2a59-4d08-8d29-9558648bcd67 ">
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-16 16:47:36 +01:00
4feb59a369
Fix Vite File does not exist ( #8527 )
...
This should fix #8491
https://vite.dev/config/dep-optimization-options
2024-11-16 09:04:19 +01:00
b733a2f3ec
changed multiItem Field Menu Item button to tertiary ( #8517 )
...
Think a simpler fix can fix
https://github.com/twentyhq/twenty/pull/8504/files#diff-13c19c3083bfe3172351cddbdd325960072496e9d50b73919fb35aa661bcdd52
https://github.com/twentyhq/twenty/issues/8492
2024-11-16 07:02:41 +01:00
dc42315f12
fix(SingleEntitySelectMenuItems): extract Add New button from entitiesToSelect ( #8474 )
...
# Description
Closes #8169
Extract Add New button from entitiesToSelect and add it as a separate
element .
There doesn't seem to be a point in having Add New as part of a list, it
seems better off in its own component, apart from list items
## Rationale
There already is #8353 addressing the same issue, but it seems it
doesn't really remove the duplicate "Add New" in the list, leaving a
duplicate "Add New" in `SingleEntitySelect`
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-16 06:49:55 +01:00
9b2853bb01
Fix variable dropdown ( #8521 )
...
- fixed dropdown width
- add icons
- handle composite fields
## After
2024-11-15 18:08:03 +00:00
54b28ff7ed
Enable workflow testing + fix header ( #8512 )
...
- clean execution header
- enable test on workflows + add snack bar
- display snack bar error if workflow cannot be tested
Behaviour still need to be validated by @Bonapara
<img width="880" alt="Capture d’écran 2024-11-15 à 12 16 36"
src="https://github.com/user-attachments/assets/1dab0c3b-157c-449f-aee7-4c8cf2e369a6 ">
<img width="880" alt="Capture d’écran 2024-11-15 à 12 16 48"
src="https://github.com/user-attachments/assets/16279611-0a58-4fe6-b117-0192714a6d5c ">
2024-11-15 18:38:39 +01:00
ac93d35538
Fix remove no result menu from relation picker ( #8485 )
...
Fixes : #8455
1. Summary
Removed redundant `No result` menu from relation picker
2. Screenshot
https://github.com/user-attachments/assets/0bf457dc-57d6-4b38-8ef9-e985edd92396
2024-11-15 17:51:18 +01:00
9e7b90a551
fix: Added keyboard functionality for esc and Ctrl + a ( #8282 )
...
## Description
- This PR fixes
#8247
#8206
- Adds keyboard functionality for esc (deselect all records) and Ctrl +
a (select records)
## Changes
https://github.com/user-attachments/assets/7b2718d6-dbe5-4cd8-8ead-b6baed1fc357
Merged during stream 🎉
---------
Co-authored-by: Devessier <baptiste@devessier.fr >
2024-11-15 17:15:39 +01:00
4db0d0f8c1
Improve phone input UI ( #8266 )
...
[FIX] #8251
Changes made as suggested by @Bonapara.
For the `The country code should be Tertiary instead of Primary ` task,
the library "react-phone-number-input" doesn't provide any out of the
box functionality to style the country code.
If the feature **needs** to be implemented here are the possible
solution/workarounds:
1. Finding a more customizable library that allows to change the style
of the country code
OR
2. Implement custom country selection (😰 ...)
OR
3. The lib allows a custom input element and a provides a function
(onCountryChange) that triggers whenever the country changes (a country
can be changed in two ways- 1. When the user deliberately chooses it
from dropdown OR 2. Changes the code in the input)
We'll have to get the length of the country code and then style the
first X digits in the custom input field...
Let me know if someone has a better approach.
---------
Co-authored-by: Thomas des Francs <tdesfrancs@gmail.com >
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-11-15 16:03:48 +01:00
c03b1ca7c6
Improve storybook test ( #8516 )
...
Just a quick fix
2024-11-15 14:49:07 +01:00
34a3a66451
Improve flaky storybook test ( #8515 )
...
I don't think that will solve the flaky test but at least it will
cleanup the error message to avoid confusion
2024-11-15 14:29:39 +01:00
bd18eb8b42
Add logging for scopeid error ( #8513 )
...
Can't figure out https://github.com/twentyhq/twenty/issues/8347 so I'm
adding logs, maybe it'll help debug in the future!
2024-11-15 14:16:09 +01:00
30bcdda323
Modal Background & box shadow fixes ( #8506 )
...
# Before
# After
2024-11-15 12:44:58 +01:00
4f99b8eea1
8495 workflow display relevant columns in workflow related tables ( #8502 )
...
## After
### Workflows
### WorkflowRuns
### WorkflowVersions
## Change Created By into Executed By in workflowRuns
2024-11-15 10:13:36 +00:00
5384b4aba5
Fix record board export not taking filters into account ( #8505 )
...
Fix Export CSV action not taking into account the filters applied on the
Kanban index view
2024-11-14 23:28:53 +01:00
a799370483
Aggregated queries #1 ( #8345 )
...
First step of https://github.com/twentyhq/twenty/issues/6868
Adds min.., max.. queries for DATETIME fields
adds min.., max.., avg.., sum.. queries for NUMBER fields
(count distinct operation and composite fields such as CURRENCY handling
will be dealt with in a future PR)
<img width="1422" alt="Capture d’écran 2024-11-06 à 15 48 46"
src="https://github.com/user-attachments/assets/4bcdece0-ad3e-4536-9720-fe4044a36719 ">
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
Co-authored-by: Weiko <corentin@twenty.com >
2024-11-14 18:05:05 +01:00
c966533f26
fix: search error in filter & sort dropdowns ( #8493 )
...
Fixes : #8483
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-14 17:51:54 +01:00
51c54d4c5b
validation on Select field ( #8316 )
...
fix #8204
I changed "API keys" to "API values".
Stopped inputting special characters in Select field option keys.
@lucasbordeau please check the changes and tell me if I need to do any
other changes. :)
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-14 17:46:18 +01:00
15b8b9b158
Feature : Adding percentage option to Input Number ( #8481 )
...
fixing #7375
---------
Co-authored-by: guillim <guillaume@twenty.com >
2024-11-14 14:23:25 +01:00
9ac949dec8
[Workflow] Add search in variable dropdown ( #8479 )
...
- fix Icon variable Plus
- add search input
- fix dropdown height
## Before
## After
2024-11-14 11:40:06 +01:00
c98a8a2258
fix: dropdown toggle functionality ( #8476 )
...
Fixes : #8468
2024-11-13 19:36:21 +01:00
2fb920f68c
Fix typo in branch name ( #8480 )
...
Fixes #8471
Updated `0.33.0-canaray` -> `0.33.0-canary`
2024-11-13 19:35:15 +01:00
795cb12a12
minor fix - spacing on Data model title fixed ( #8467 )
2024-11-13 19:34:15 +01:00
898006f89d
Prevent automatic zoom when focusing inputs on iOS ( #8477 )
...
This is the result of a long discussion we had here:
https://github.com/twentyhq/twenty/issues/8001 .
The goal is to stop iOS from automatically zooming when the user focuses
on an input whose font size is less than 16px.
The options were:
1. Disable zoom for all devices
2. Disable zoom for devices detected as iOS devices, which doesn't
prevent users from zooming manually but fixes the auto-zoom bug
3. Set the font size of the inputs to be equal to or greater than
16px—this change would take a lot of time
To me, the second option is the best, as iOS prevents developers from
disabling zoom. They saw that it was overused and chose to restrict this
setting. Setting a `maximum-scale` doesn't prevent users from zooming,
but it fixes the initial bug we had.
My implementation can be seen as [progressive
enhancement](https://developer.mozilla.org/en-US/docs/Glossary/Progressive_Enhancement
): If we can detect that the user uses an iOS device, we'll set the
`maximum-scale` viewport property. Relying on the user agent is always
unstable, and the check might fail unpredictably. We might not disallow
auto-zoom for some iOS devices.
However, I think we can either:
- Invest some time to choose a more reliable user detection pattern if
the one I suggest is not sufficient ([we find many different checks on
the
internet](https://stackoverflow.com/questions/9038625/detect-if-device-is-ios ),
I'm not sure which one is the best)
- Choose to apply the viewport setting to all devices and remove the JS
code. According to my tests, it doesn't prevent zooming on desktops.
However, it does on Android phones. I think it's not lovely to disallow
zoom, but if the team agrees that we should go this way, I won't
disagree.
I know my JavaScript code does not follow a pattern we want to spread in
the app. The synchronous script will run as soon as possible to ensure
the viewport is correctly set when the website launches. This shouldn't
be an example followed by others.
Thanks, @harshit078, for your help in thinking about the best option.
I'm tagging @lucasbordeau and @charlesBochet for a technical review.
I would appreciate if someone could test on a more recent iOS device
than mine.
Here is a demonstration of the behavior on iOS:
https://github.com/user-attachments/assets/d49fb65f-dd76-455c-9ac0-d4c002a7fe89
2024-11-13 15:34:20 +01:00
ba79a1d324
Fix style ( #8475 )
...
## Before
## After
2024-11-13 13:32:40 +00:00
31f03764d6
Improve the layout of the Workflow Visualizer ( #8372 )
...
- Increase the dimensions of the ReactFlow nodes. This allows to ditch
scaling which made it hard to get the width of the nodes as they were
visually scaled by 1.3.
- Center the flow when the flow mounts and when the state of the right
drawer opens.
- Put the node type inside of the node so it doesn't overlap with the
arrow
- Make the edges non deletable
We'll have to make a refactor so the viewport can be animated properly:
https://github.com/twentyhq/twenty/issues/8387 .
https://github.com/user-attachments/assets/69494a32-5403-4898-be75-7fc38058e263
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-12 17:52:12 +01:00
bec4da496d
Data settings new layout - anchor navigation ( #8334 )
...
Follow-up of https://github.com/twentyhq/twenty/pull/7979
Navigation between settings and fields tabs is now reflected in URL.
<img width="1106" alt="Capture d’écran 2024-11-07 à 18 38 57"
src="https://github.com/user-attachments/assets/24b153ef-9e68-4aa2-8e3a-6bf70834c5ad ">
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com >
Co-authored-by: Weiko <corentin@twenty.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-11-11 14:06:38 +01:00
9d6a850ee8
Mark main version as 0.33 canary ( #8453 )
2024-11-11 11:59:33 +01:00
29d92abaff
fix: bookmarkIcon flash on hover exit ( #8448 )
...
Fixes : #8447
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-11 09:30:03 +01:00
c19e54f24b
Hide tabs ( #7841 )
...
@FelixMalfait WDYT?
We can refactor shouldDisplay Files/Tasks/Notes Tab etc into a hook.
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-11 09:26:27 +01:00
6d62dd9fd1
fix: object activate dropdown ( #8438 )
...
Fixes : #8436
Fixes : #8435
& other duplicate ```DropdownMenu```
2024-11-11 09:26:07 +01:00
51d1305e27
fix: timeline padding ( #8440 )
...
Fixes : #8437
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-09 08:19:28 +01:00
8ee827d05d
fix: Developers page dropdown not optimised for mobile viewport ( #8392 )
...
## Description
- This PR is a minor fix to issue #8379
- Fixed dropdown for mobile viewports
## Changes
https://github.com/user-attachments/assets/76692233-996e-4a1a-884a-84d31464fc85
2024-11-09 07:59:15 +01:00
e3e638579b
[FIX] Text overflow on timeline ( #8325 )
...
FIX : #6977
Implementation:
1. Parent (Summary componenet) width is set to 100%. (dosen't grow even
if the child exceeds width)
2. span element is set to `text-overflow: ellipses` when overflown.
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-08 18:20:41 +00:00
6ec8a5b76e
[FIX] slash-menu-height-fix ( #8327 )
...
FIX #8326
I've used the `height: fit-content` property just for customSlashMenu
but I think it will work for all dropdown menu's.
I tested it for a few and works fine, but not sure for edge cases.
Let me know if the height should be changed to `fir-content`
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-11-08 16:22:18 +00:00
354ee86cb9
8311 serverless function functions can be executed with any input ( #8380 )
...
- remove ts-morph
- update inputSchema shape
https://github.com/user-attachments/assets/913cd305-9e7c-48da-b20f-c974a8ac7cea
## TODO
- have inputTypes to match the inputSchema type (string, number,
boolean, etc...), only string for now
- handle required/optional inputs
- handle case when inputSchema changes, fix data reset when switching
function
2024-11-08 16:15:27 +00:00
0381996fb9
fix: dropdown menu doesn't close and remains open ( #8302 )
...
## Description
- Fixes #8285
- Added fix for both Currency and PhoneCountry dropdown
## Changes
https://github.com/user-attachments/assets/cbf85100-7791-40da-a676-2c87c6a32976
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-11-08 16:13:15 +00:00
045f569d62
Fixed dropdown menu field settings ( #8374 )
...
2 dropdown menu components were used. Using only one and using dropdown
props for passing width to its internal dropdown menu component.
2024-11-08 17:11:37 +01:00
e8bf81de5b
8172 update the right drawer action menu to open with command o ( #8375 )
...
Closes #8172
- Added a shortcut property to the button component
- Displays the actions inside a dropdown
- The dropdown is toggled either by clicking on the button or with the
`command + O` shortcut
https://github.com/user-attachments/assets/4c4c88fa-85dc-404e-bb42-f2b0d57c8960
2024-11-08 17:08:09 +01:00
