twenty

2 Commits

Author SHA1 Message Date

Author	SHA1	Message	Date
Nicolas RouanneandFélix Malfait	dc42315f12	fix(SingleEntitySelectMenuItems): extract `Add New` button from entitiesToSelect (#8474 ) # Description Closes #8169 Extract Add New button from entitiesToSelect and add it as a separate element . There doesn't seem to be a point in having Add New as part of a list, it seems better off in its own component, apart from list items ## Rationale There already is #8353 addressing the same issue, but it seems it doesn't really remove the duplicate "Add New" in the list, leaving a duplicate "Add New" in `SingleEntitySelect` --------- Co-authored-by: Félix Malfait <felix@twenty.com>	2024-11-16 06:49:55 +01:00
Nicolas Rouanne	cde96cf526	Fix/validate access token user not found (#8484 ) # Description Closes #7244 See details about implementation: https://github.com/twentyhq/twenty/issues/7244#issuecomment-2473845859 and https://github.com/twentyhq/twenty/issues/7244#issuecomment-2473905514 # Changes - return a `USER_NOT_FOUND` error instead of `INVALID_INPUT` error - tweak unit tests to correctly test `AuthExceptionCode`, as it wasn't properly tested; it was actually a _false positive_. This is because [`toThrow`](https://jestjs.io/docs/expect#tothrowerror) from jest only checks the `message`, and not any other method / attributes from the `Error`. It's a know behaviour and not considered a bug, see https://github.com/jestjs/jest/issues/13232#issuecomment-1252392845	2024-11-13 18:50:30 +01:00

dc42315f12

fix(SingleEntitySelectMenuItems): extract Add New button from entitiesToSelect (#8474 )

# Description
Closes #8169

Extract Add New button from entitiesToSelect and add it as a separate
element .
There doesn't seem to be a point in having Add New as part of a list, it
seems better off in its own component, apart from list items

## Rationale
There already is #8353 addressing the same issue, but it seems it
doesn't really remove the duplicate "Add New" in the list, leaving a
duplicate "Add New" in `SingleEntitySelect`

---------

Co-authored-by: Félix Malfait <felix@twenty.com>

2024-11-16 06:49:55 +01:00

Nicolas Rouanne

cde96cf526

Fix/validate access token user not found (#8484 )

# Description
Closes #7244 

See details about implementation:
https://github.com/twentyhq/twenty/issues/7244#issuecomment-2473845859
and
https://github.com/twentyhq/twenty/issues/7244#issuecomment-2473905514

# Changes
- return a `USER_NOT_FOUND` error instead of `INVALID_INPUT` error
- tweak unit tests to correctly test `AuthExceptionCode`, as it wasn't
properly tested; it was actually a _false positive_. This is because
[`toThrow`](https://jestjs.io/docs/expect#tothrowerror) from jest only
checks the `message`, and not any other method / attributes from the
`Error`. It's a know behaviour and not considered a bug, see
https://github.com/jestjs/jest/issues/13232#issuecomment-1252392845

2024-11-13 18:50:30 +01:00