Nabhag Motivaras
081f5fa766
Sort menu Incorrect padding bottom #11078 ( #11091 )
...
## Issue
- Closes #11078
- **visual regression** from PR - #9159 that likely might have break
visuals in several other places.
2025-03-21 16:29:30 +01:00
Nabhag Motivaras and Lucas Bordeau
3793f6c451
fix: content getting hide on drag and drop in stage view cards ( #7621 )
...
## ISSUE
- Closes #7388
## Demo
https://github.com/user-attachments/assets/193813aa-def9-406b-9fe7-397627bb1242
- [ ] Table Row Drag WIP
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-11-05 16:03:24 +01:00
Nabhag Motivaras
ac88840bf0
fix: redis url to not be optional anymore ( #7850 )
...
## Description
- `REDIS_URL` is required
<img width="1903" alt="Redis Required"
src="https://github.com/user-attachments/assets/5b53a4a6-29f4-4473-b7e4-52489f75204e ">
----
- Closes #7849
- Might be related #7768
---
- Wasn't gracefully reseting database
```
npx nx database:reset twenty-server
```
2024-10-19 17:22:47 +02:00
Nabhag Motivaras
508252b14c
fix: API ObjectMetadata labelSingular and labelPlural which eventually solves typo in dropdown ( #7614 )
...
## ISSUE
- Closes #7478
## Description
- Fixes typo in dropdown + in general any apikeys label around.
2024-10-13 19:37:39 +02:00
Nabhag Motivaras and Charles Bochet
8becedf552
[OSS.GG] Gif Magic Side Quest ( #7644 )
...
# Side Quest Challenge: GIF Magic
- GIF Link:
https://giphy.com/gifs/twenty-twentycrm-opensourcecrm-wCcsmnJuzzzGrfuf9B
- Related Tweet Link:
https://x.com/NabhagMotivaras/status/1845455575716352363
#### For Fun added Music to Video I recorded hehe.
https://github.com/user-attachments/assets/bedebc33-82a4-4e78-a4b2-19ab25dab364
### - Thank you Raycast 🚀
Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com >
2024-10-13 16:20:58 +02:00
Nabhag Motivaras
8967181212
[oss.gg] Like & Retweet side quest ( #7641 )
...
### Side Quest: Like and Retweet
----
<img width="608" alt="Like Launch Tweet"
src="https://github.com/user-attachments/assets/c03a651e-890d-49e6-bc19-bb7b02d2b671 ">
---
<img width="608" alt="RetweetSideQuest"
src="https://github.com/user-attachments/assets/58ff243a-10f0-4071-aada-7fafe7894068 ">
2024-10-13 15:56:14 +02:00
Nabhag Motivaras and Lucas Bordeau
539dc9506d
fix: filter and sort options to match order of table columns ( #7392 )
...
### ISSUE
- Closes #5960
### Demo
https://github.com/user-attachments/assets/279b19cf-6841-4a63-82ed-423bc0eb4395
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-10-10 17:05:22 +02:00
Nabhag Motivaras and Lucas Bordeau
c97c71762e
fix: Input fields to have expected behaviour in case of empty / only whitespaces string ( #6736 )
...
# ISSUE
- Closes #6734
- Closes #6633
- Closes #6733
- Closes #6816
# Description
- [x] Don't allow Empty (whitespaces) Objects to Create, all the
keyboard shortcuts are also handled for this.
https://github.com/user-attachments/assets/1c9add4e-f13f-458b-8f76-63bd868413a2
https://github.com/user-attachments/assets/e72b6ee3-74e4-4517-a230-3eb10db80dc7
Note: we do have one other issue with FullName field #6740 Inorder to
test use **shift**.
- [x] Api Keys Input Name Field -> New and Detail View Name field
shouldn't be empty or string with whitespaces, we won't able to have
whitespaces in both. **Try Entering just spaces**
https://github.com/user-attachments/assets/b521b49f-648c-4585-9d15-8ff4faed3c3a
- [x] Similar to above, Empty webhook endpoint url under
**/settings/developers/webhooks/new** won't be created. **Try Entering
just spaces**
- [x] New Functions or Updating Functions will not able to have
whitespaces, empty string as Name. **Try Entering just spaces**
https://github.com/user-attachments/assets/09fcf394-c6d9-4080-8efd-462b054a22d0
- [x] under **settings/workspace-members** changes will lead and solve
that user won't be able to enter Invite by email as just whitespaces +
button is now getting disabled when there is no correct email. **Try
Entering just spaces**
https://github.com/user-attachments/assets/b352edfa-113b-4645-80fd-db6f120ab5db
- [x] Text Input Field, will not allow to start entering with
whitespaces and won't take just whitespaces as value spaces between
words will work.
https://github.com/user-attachments/assets/8c1a0812-45be-4ed2-bd3d-bb4f92147976
- [x] Similarly Number works as per above including shortcuts.
https://github.com/user-attachments/assets/9f69cc87-5c3c-43ee-93c4-fa887bc0d7ee
- [x] Similarly FullName field works as per above including shortcuts
https://github.com/user-attachments/assets/7bb006b2-abf7-44cd-a214-7a2fc68df169
- [x] Pasting fullName is been Improved.
- Case 1 (Two Words): If there are exactly two words, return them as is.
- Case 2 (More than Two Words): If there are more than two words, return
the first two words only.
- Case 3 (One Word): If there is only one word, return it as the first
name, with an empty string as the last name.
- WhiteSpaces have been handled.
```
console.log(splitFullName("John Doe")); // ["John", "Doe"]
console.log(splitFullName(" ")); // ["", ""]
console.log(splitFullName("John")); // ["John", ""]
console.log(splitFullName(" John Doe ")); // ["John", "Doe"]
console.log(splitFullName("John Michael Andrew Doe")); // ["John", "Michael"]
```
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-09-20 21:25:50 +02:00
Nabhag Motivaras
2edab3fa2c
fix: ability to create empty kanban ( #6951 )
...
## ISSUE
- Closes #6946
2024-09-09 16:10:40 +02:00
Nabhag Motivaras
c0d0f8d78d
fix: settings search field bottom padding ( #6920 )
...
## ISSUE
- Closes #6919
2024-09-06 15:13:35 +02:00
Nabhag Motivaras
6e7cb27af2
fix: securing tasks and notes all view ( #6869 )
...
ISSUE
- Closes #6863
2024-09-03 09:16:42 +02:00
Nabhag Motivaras and Charles Bochet
ea7b9e90c9
fix: EmailThreads and Calendar making one extra graphql requests even total records are fetched ( #6814 )
...
## ISSUE (BUG)
- Closes #5282
## Description
- [x] Email Threads Tab was making two graphql requests
**[GetTimelineThreadsFromCompanyId]** when navigating after a first
render of record page, once only, later it was making only one.
- [x] Similarly Calendar Tab
**[GetTimelineCalendarEventsFromCompanyId]**
### Before
https://github.com/user-attachments/assets/c234b7b4-fe7d-4655-92d6-0a6817fda6b5
### After
https://github.com/user-attachments/assets/80af33c7-b801-4377-a59a-47c43e0fecdd
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-08-31 14:22:33 +02:00
Nabhag Motivaras
9a3f29b9a0
fix: relation and record chip height ( #6758 )
...
# ISSUE
- Closes #6756
After Changes:
https://github.com/user-attachments/assets/1885be11-b50a-4b05-afae-d2f02a403ad6
https://github.com/user-attachments/assets/edc6a913-95a6-4c75-8ec2-83e2c27fddb0
2024-08-29 11:42:42 +02:00
Nabhag Motivaras and Lucas Bordeau
747a1549e9
fix: defaultHomePagePath to be last visited page or alphatically first active object with the name ( #6629 )
...
### ISSUE
- Closes #6612
- Closes #6125
- Closes #5949
- Closes #6652
### Description
- [x] need to check changes in jest test.
- [x] fallback to alphabetically firstActiveObject with the name if no
last visited exist
https://github.com/user-attachments/assets/dd11480b-c47f-4393-9857-8a55467061e3
- [x] fallback to last visited page with the last visited view by
default if no views would have toggled with subNav or viewChangeDropdown
it will fallback to INDEX or if no INDEX view then zero position view,
works with both subNavViewBar and viewChangeDropdown.
https://github.com/user-attachments/assets/33e97e55-2aa2-4c45-a3ab-fc8e43f4964c
https://github.com/user-attachments/assets/d1db76a2-da59-4cd2-81bf-d6119408fbbf
- [x] lastVisited view across the objects have been persisted so now
navigating back from x object to y or z to x will open always last
visited view and defaults to index or zero position view.
https://github.com/user-attachments/assets/70a01a11-a7ef-4031-926e-02923551466c
- [x] lastVisited Page with view has been persisted across the
workspace, scope is per workspace so jumping between workspace will also
work to have lastvisited object of particular workspace.
https://github.com/user-attachments/assets/25107339-8ec1-4421-9f6e-1da43b8f4816
- [x] when lastVisitedObject has been deactivated and going back from
settings should have a fallback Object that is alphabetically First
activeObject.
https://github.com/user-attachments/assets/6b24a933-b139-49ac-82b2-eac5e4848516
- [x] Creation of new View of **anyType** should also get persist and
that should get lastVisitedObject with View in case the user leaves from
there right away.
https://github.com/user-attachments/assets/80ff7114-051d-4e9b-ab58-0e1e3a7d328c
- [x] Similarly deleted view also works.
https://github.com/user-attachments/assets/cb0b8043-fba4-4a66-941d-b3fa0a57eb22
- [x] fixed active subnav background when opening object directly with
root path **/** , it wasn't showing active subNav background.
Before:
https://github.com/user-attachments/assets/db341c4a-f1f9-43c4-9838-37d1a1f5ab8e
Fixed:
https://github.com/user-attachments/assets/0f0fd492-bc5d-4efe-b695-bee4e3f41d4e
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-08-28 17:15:54 +02:00
Nabhag Motivaras
20d84755bb
fix: exclude tabler/icons-react from optimizeDeps to avoid crashing performance CI ( #6621 )
...
## ISSUE (Warning)
- Fixes #6437
### Things needed to investigate :
- [x] Can we exclude @tabler-icons from Babel / wyw-in-js / the vite
config of Storybook ?
> Yes we can
- [ ] Is there a reproducible difference between non-Linaria components
loading time and Linaria components loading times ?
> Couldn't find anything related to this, yet. but changes fix the
problem.
2024-08-16 16:18:45 +02:00
Nabhag Motivaras and Lucas Bordeau
197bca57ba
feat(e2e): twenty-e2e-testing with playwright ( #6539 )
...
## ISSUE (e2e) - Introduces e2e for twenty
- Closes #6360
## Description
- [x] Create Package.
- [x] Setup environments such as baseUrl.
- [x] ignore CI configuration for now.
- [x] write a simple test to check if table is visible in companies tab.
### Running test with UI
```
yarn run test:e2e:ui
```
https://github.com/user-attachments/assets/a7b7ae35-8898-461e-8c7c-d3e4e9515aeb
### Running all test and seeing report
```
yarn run test:e2e
yarn run test:e2e:report
```
https://github.com/user-attachments/assets/2558a1f9-97cc-4f06-86f0-806f207eac5a
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-08-14 17:23:32 +02:00
Nabhag Motivaras
b16437e6c8
fix: column overlay issue in record table header cells ( #6609 )
...
### Issue (BUG)
- Fixes #6604
### Description
- Now Columns doesn't overlay on header cells, issue was independant of
field type.
#### Before
https://github.com/user-attachments/assets/0872f07a-83b2-44d8-8f8e-c61c5fac5278
#### After
https://github.com/user-attachments/assets/e2e623f6-6635-4ab6-8ca2-cbd3a296c27d
2024-08-11 20:48:31 +02:00
Nabhag Motivaras
320742cdea
[Fix] URL inputs to not submit numeric hostnames and url without domain ( #6482 )
...
## ISSUE (BUG)
- Fixes #5396
## Description
- When given a string like **https://300 **, it interprets 300 as the
hostname, which it then converts to an IP address, what i did was to
check if the entire string (ignoring the protocol ) is number then don't
submit it all within zod and it makes sense to do that cause.
- The range for valid 32-bit unsigned integers is 0 to 4294967295 (which
corresponds to 0.0.0.0 to 255.255.255.255) so other than this numbers by
default URL objects throws invalid.
https://github.com/user-attachments/assets/1da92aeb-d50c-43a3-87ea-78a059d3fa84
2024-08-08 17:42:36 +02:00
Nabhag Motivaras
e265efcf90
fix(wip): tasks navigate to /objects/tasks with viewId ( #6528 )
...
ISSUE (BUG)
Fixes : #6523
Description:
- [ ] Should work on Command Menu
- [ ] Should also work on Global Goto Hotkeys
- [ ] Should navigate with viewId, as when we click on Navigationbar it
is navigating with viewId.
2024-08-07 18:00:41 +02:00
Nabhag Motivaras
f09e61bb9f
fix: vite to allow serve fonts from blocknote and any files from root of workspace ( #6552 )
...
## ISSUE
- Fixes #6546
## Description
- Now we don't get error logs and we are allowing vite to serve from
blocknote and root workspace.
2024-08-07 11:12:33 +02:00
Nabhag Motivaras
b841187319
fix: releases list to have styles according to theme ( #6534 )
...
### ISSUE (BUG)
- Fixes : #6524
### DESCRIPTION
- List styles wasn't applying based on the theme, reason for applying
css to directly to **li** and **li strong** instead of applying to
unorderlist-element is that later on we might have **orderlist** in that
case if we had apply to **ul** here, this will issue will be raised
again, thus in **list element**
https://github.com/user-attachments/assets/64f0870e-4f82-4afd-8452-778aa54023fc
2024-08-05 14:42:20 +02:00
Nabhag Motivaras