twenty

6,811 Commits 1 Branch 0 Tags

3 Commits

Author	SHA1	Message	Date
Ajay A Adsule	da35a2f479	fix: trigger onClickOutside when click escape for closing the model a… (#12461 ) Description: Resolved a bug where pressing the Escape key did not clear the filter chips when no filter value was present. Added a call to onClickOutside inside the useScopedHotkeys hook to ensure filter chips are removed when Escape is pressed and the dropdown is open but empty. https://github.com/user-attachments/assets/42ed35b0-f5a8-4d26-8407-fdd5e2cc4a42 fix #12319	2025-06-09 15:08:57 +02:00
Ajay A Adsule	efffac2a1a	Deleted view disable delete btn (#11990 ) This PR updates the defaultRecordActionConfig for the SingleRecordActionKeys.DELETE action. A condition !isSoftDeleteFilterActive was added to the shouldBeRegistered function to ensure the delete button is only visible when the deleted records view is not selected. This prevents the delete button from appearing when viewing deleted records. #11974 ![Screenshot 2025-05-12 at 9 41 30 PM](https://github.com/user-attachments/assets/ab7c1f61-d5ab-4315-9f39-50108d11438c) ![Screenshot 2025-05-12 at 9 42 11 PM](https://github.com/user-attachments/assets/82a9843b-4d5e-406c-8186-dce5b7b16bf3)	2025-05-13 14:00:15 +02:00
Ajay A AdsuleandFélix Malfait	c4482f6be6	fix: avoid passing invalid to prop to DOM (#11931 ) Fixed a React warning caused by the to prop being passed to the DOM when its value was undefined or false. Since to is not a valid HTML attribute, this triggered a console error. The prop is only used for styling logic, so I used Emotion’s shouldForwardProp to prevent it from being passed to the DOM, resolving the issue cleanly. ![Screenshot 2025-05-07 at 10 00 54 PM](https://github.com/user-attachments/assets/0660af7f-df98-46a3-b9f2-2ccc993ac227) #11850 --------- Co-authored-by: Félix Malfait <felix@twenty.com>	2025-05-07 21:12:15 +02:00

Author

SHA1

Message

Date

Ajay A Adsule

da35a2f479

fix: trigger onClickOutside when click escape for closing the model a… (#12461 )

Description:
Resolved a bug where pressing the Escape key did not clear the filter
chips when no filter value was present.
Added a call to onClickOutside inside the useScopedHotkeys hook to
ensure filter chips are removed when Escape is pressed and the dropdown
is open but empty.



https://github.com/user-attachments/assets/42ed35b0-f5a8-4d26-8407-fdd5e2cc4a42

fix #12319

2025-06-09 15:08:57 +02:00

Ajay A Adsule

efffac2a1a

Deleted view disable delete btn (#11990 )

This PR updates the defaultRecordActionConfig for the
SingleRecordActionKeys.DELETE action. A condition
!isSoftDeleteFilterActive was added to the shouldBeRegistered function
to ensure the delete button is only visible when the deleted records
view is not selected.

This prevents the delete button from appearing when viewing deleted
records.

#11974  

![Screenshot 2025-05-12 at 9 41
30 PM](https://github.com/user-attachments/assets/ab7c1f61-d5ab-4315-9f39-50108d11438c)

![Screenshot 2025-05-12 at 9 42
11 PM](https://github.com/user-attachments/assets/82a9843b-4d5e-406c-8186-dce5b7b16bf3)

2025-05-13 14:00:15 +02:00

Ajay A AdsuleandFélix Malfait

c4482f6be6

fix: avoid passing invalid to prop to DOM (#11931 )

Fixed a React warning caused by the to prop being passed to the DOM when
its value was undefined or false. Since to is not a valid HTML
attribute, this triggered a console error. The prop is only used for
styling logic, so I used Emotion’s shouldForwardProp to prevent it from
being passed to the DOM, resolving the issue cleanly.

![Screenshot 2025-05-07 at 10 00
54 PM](https://github.com/user-attachments/assets/0660af7f-df98-46a3-b9f2-2ccc993ac227)

#11850

---------

Co-authored-by: Félix Malfait <felix@twenty.com>

2025-05-07 21:12:15 +02:00