# Introduction Diff description: ~500 tests and +500 additions close https://github.com/twentyhq/core-team-issues/issues/731 ## What has been done here In a nutshell on a field metadata type ( `SELECT MULTI_SELECT` ) update, we will be browsing all `ViewFilters` in a post hook searching for some referencing related updated `fieldMetadata` select. In order to update or delete the `viewFilter` depending on the associated mutations. ## How to test: - Add FieldMetadata `SELECT | MULTI_SELECT` to an existing or a new `objectMetadata` - Create a filtered view on created `fieldMetadata` with any options you would like - Remove some options ( in the best of the world some that are selected by the filter ) from the `fieldMetadata` settings page - Go back to the filtered view, removed or updated options should have been hydrated in the `displayValue` and the filtered data should make sense ## All filtered options are deleted edge case If an update implies that a viewFilter does not have any existing related options anymore, then we remove the viewFilter ## Testing ```sh PASS test/integration/metadata/suites/field-metadata/update-one-field-metadata-related-record.integration-spec.ts (27 s) update-one-field-metadata-related-record SELECT ✓ should delete related view filter if all select field options got deleted (2799 ms) ✓ should update related multi selected options view filter (1244 ms) ✓ should update related solo selected option view filter (1235 ms) ✓ should handle partial deletion of selected options in view filter (1210 ms) ✓ should handle reordering of options while maintaining view filter values (1487 ms) ✓ should handle no changes update of options while maintaining existing view filter values (1174 ms) ✓ should handle adding new options while maintaining existing view filter (1174 ms) ✓ should update display value with options label if less than 3 options are selected (1249 ms) ✓ should throw error if view filter value is not a stringified JSON array (1300 ms) MULTI_SELECT ✓ should delete related view filter if all select field options got deleted (1127 ms) ✓ should update related multi selected options view filter (1215 ms) ✓ should update related solo selected option view filter (1404 ms) ✓ should handle partial deletion of selected options in view filter (1936 ms) ✓ should handle reordering of options while maintaining view filter values (1261 ms) ✓ should handle no changes update of options while maintaining existing view filter values (1831 ms) ✓ should handle adding new options while maintaining existing view filter (1610 ms) ✓ should update display value with options label if less than 3 options are selected (1889 ms) ✓ should throw error if view filter value is not a stringified JSON array (1365 ms) Test Suites: 1 passed, 1 total Tests: 18 passed, 18 total Snapshots: 18 passed, 18 total Time: 27.039 s ``` ## Out of scope - We should handle ViewFilter validation when extracting its definition from the metadata https://github.com/twentyhq/core-team-issues/issues/1009 ## Concerns - Are we able through the api to update an RATING fieldMetadata ? ( if yes than that's an issue and we should handle RATING the same way than for SELECT and MULTI_SELECT ) - It's not possible to group a view from a MULTI_SELECT field The above points create a double nor a triple "lecture" to the post hook effect: - ViewGroup -> only SELECT - VIewFilter -> only SELECT || MULTI_SELECT - Rating nothing I think we should determine the scope of all of that --------- Co-authored-by: Charles Bochet <charles@twenty.com>
127 lines
3.9 KiB
TypeScript
127 lines
3.9 KiB
TypeScript
import { useApolloClient, useMutation } from '@apollo/client';
|
|
|
|
import {
|
|
UpdateOneFieldMetadataItemMutation,
|
|
UpdateOneFieldMetadataItemMutationVariables,
|
|
} from '~/generated-metadata/graphql';
|
|
|
|
import { UPDATE_ONE_FIELD_METADATA_ITEM } from '../graphql/mutations';
|
|
|
|
import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState';
|
|
import { useRefreshObjectMetadataItems } from '@/object-metadata/hooks/useRefreshObjectMetadataItem';
|
|
import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
|
|
import { useFindManyRecordsQuery } from '@/object-record/hooks/useFindManyRecordsQuery';
|
|
import { GET_CURRENT_USER } from '@/users/graphql/queries/getCurrentUser';
|
|
import { useSetRecoilState } from 'recoil';
|
|
|
|
import { getRecordsFromRecordConnection } from '@/object-record/cache/utils/getRecordsFromRecordConnection';
|
|
import { RecordGqlConnection } from '@/object-record/graphql/types/RecordGqlConnection';
|
|
import { useSetRecordGroups } from '@/object-record/record-group/hooks/useSetRecordGroups';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
import { useApolloMetadataClient } from './useApolloMetadataClient';
|
|
|
|
export const useUpdateOneFieldMetadataItem = () => {
|
|
const apolloMetadataClient = useApolloMetadataClient();
|
|
const apolloClient = useApolloClient();
|
|
const { refreshObjectMetadataItems } =
|
|
useRefreshObjectMetadataItems('network-only');
|
|
|
|
const { setRecordGroupsFromViewGroups } = useSetRecordGroups();
|
|
const cache = useApolloClient().cache;
|
|
|
|
const setCurrentWorkspace = useSetRecoilState(currentWorkspaceState);
|
|
|
|
const { findManyRecordsQuery: findManyViewsQuery } = useFindManyRecordsQuery({
|
|
objectNameSingular: CoreObjectNameSingular.View,
|
|
recordGqlFields: {
|
|
id: true,
|
|
viewGroups: {
|
|
id: true,
|
|
fieldMetadataId: true,
|
|
isVisible: true,
|
|
fieldValue: true,
|
|
position: true,
|
|
},
|
|
},
|
|
});
|
|
|
|
const [mutate] = useMutation<
|
|
UpdateOneFieldMetadataItemMutation,
|
|
UpdateOneFieldMetadataItemMutationVariables
|
|
>(UPDATE_ONE_FIELD_METADATA_ITEM, {
|
|
client: apolloMetadataClient ?? undefined,
|
|
});
|
|
|
|
const updateOneFieldMetadataItem = async ({
|
|
objectMetadataId,
|
|
fieldMetadataIdToUpdate,
|
|
updatePayload,
|
|
}: {
|
|
objectMetadataId: string;
|
|
fieldMetadataIdToUpdate: UpdateOneFieldMetadataItemMutationVariables['idToUpdate'];
|
|
updatePayload: Pick<
|
|
UpdateOneFieldMetadataItemMutationVariables['updatePayload'],
|
|
| 'description'
|
|
| 'icon'
|
|
| 'isActive'
|
|
| 'label'
|
|
| 'name'
|
|
| 'defaultValue'
|
|
| 'options'
|
|
| 'isLabelSyncedWithName'
|
|
>;
|
|
}) => {
|
|
const result = await mutate({
|
|
variables: {
|
|
idToUpdate: fieldMetadataIdToUpdate,
|
|
updatePayload: updatePayload,
|
|
},
|
|
});
|
|
|
|
const objectMetadataItemsRefreshed = await refreshObjectMetadataItems();
|
|
|
|
const { data } = await apolloClient.query({ query: GET_CURRENT_USER });
|
|
setCurrentWorkspace(data?.currentUser?.currentWorkspace);
|
|
|
|
const { data: viewConnection } = await apolloClient.query<{
|
|
views: RecordGqlConnection;
|
|
}>({
|
|
query: findManyViewsQuery,
|
|
variables: {
|
|
filter: {
|
|
objectMetadataId: {
|
|
eq: objectMetadataId,
|
|
},
|
|
},
|
|
},
|
|
fetchPolicy: 'network-only',
|
|
});
|
|
|
|
const viewRecords = getRecordsFromRecordConnection({
|
|
recordConnection: viewConnection?.views,
|
|
});
|
|
|
|
for (const view of viewRecords) {
|
|
const correspondingObjectMetadataItemRefreshed =
|
|
objectMetadataItemsRefreshed?.find(
|
|
(item) => item.id === objectMetadataId,
|
|
);
|
|
|
|
if (isDefined(correspondingObjectMetadataItemRefreshed)) {
|
|
setRecordGroupsFromViewGroups(
|
|
view.id,
|
|
view.viewGroups,
|
|
correspondingObjectMetadataItemRefreshed,
|
|
);
|
|
}
|
|
cache.evict({ id: `Views:${view.id}` });
|
|
}
|
|
|
|
return result;
|
|
};
|
|
|
|
return {
|
|
updateOneFieldMetadataItem,
|
|
};
|
|
};
|