mukeshs/twenty_crm
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: standardize trigger labels to lowercase (#13140)

Browse Source 
Updated trigger labels across various components to use lowercase
formatting for consistency. This includes changes in the
WorkflowVisualizerPage, DatabaseTriggerDefaultLabel, and other related
files. The adjustments enhance readability and maintain a uniform style
throughout the application.

---------

Co-authored-by: martmull <martmull@hotmail.fr>
This commit is contained in:
kahkashan shaik
2025-07-15 15:35:45 +05:30
committed by GitHub
parent 3698c683db
commit eed502778a
8 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/twenty-e2e-testing/lib/fixtures/blank-workflow.ts
View File

@ -46,16 +46,16 @@ export class WorkflowVisualizerPage {
}; };
#triggerNames: Record<WorkflowTriggerType, string> = { #triggerNames: Record<WorkflowTriggerType, string> = {
'record-created': 'Record is Created', 'record-created': 'Record is created',
'record-updated': 'Record is Updated', 'record-updated': 'Record is updated',
'record-deleted': 'Record is Deleted', 'record-deleted': 'Record is deleted',
manual: 'Launch manually', manual: 'Launch manually',
}; };
#createdTriggerNames: Record<WorkflowTriggerType, string> = { #createdTriggerNames: Record<WorkflowTriggerType, string> = {
'record-created': 'Record is Created', 'record-created': 'Record is created',
'record-updated': 'Record is Updated', 'record-updated': 'Record is updated',
'record-deleted': 'Record is Deleted', 'record-deleted': 'Record is deleted',
manual: 'Launch manually', manual: 'Launch manually',
}; };

4
packages/twenty-front/src/modules/workflow/workflow-diagram/utils/getWorkflowDiagramTriggerNode.ts
View File

@ -18,13 +18,13 @@ export const getWorkflowDiagramTriggerNode = ({
switch (trigger.type) { switch (trigger.type) {
case 'MANUAL': { case 'MANUAL': {
triggerDefaultLabel = 'Manual Trigger'; triggerDefaultLabel = 'Manual trigger';
triggerIcon = getTriggerIcon(trigger); triggerIcon = getTriggerIcon(trigger);
break; break;
} }
case 'CRON': { case 'CRON': {
triggerDefaultLabel = 'On a Schedule'; triggerDefaultLabel = 'On a schedule';
triggerIcon = getTriggerIcon(trigger); triggerIcon = getTriggerIcon(trigger);
break; break;

6
packages/twenty-front/src/modules/workflow/workflow-trigger/constants/DatabaseTriggerDefaultLabel.ts
View File

@ -1,5 +1,5 @@
export enum DatabaseTriggerDefaultLabel { export enum DatabaseTriggerDefaultLabel {
RECORD_IS_CREATED = 'Record is Created', RECORD_IS_CREATED = 'Record is created',
RECORD_IS_UPDATED = 'Record is Updated', RECORD_IS_UPDATED = 'Record is updated',
RECORD_IS_DELETED = 'Record is Deleted', RECORD_IS_DELETED = 'Record is deleted',
} }

2
packages/twenty-front/src/modules/workflow/workflow-trigger/constants/OtherTriggerTypes.ts
View File

@ -11,7 +11,7 @@ export const OTHER_TRIGGER_TYPES: Array<{
icon: 'IconHandMove', icon: 'IconHandMove',
}, },
{ {
defaultLabel: 'On a Schedule', defaultLabel: 'On a schedule',
type: 'CRON', type: 'CRON',
icon: 'IconClock', icon: 'IconClock',
}, },

10
packages/twenty-front/src/modules/workflow/workflow-trigger/utils/__tests__/getTriggerDefaultDefinition.test.ts
View File

@ -1,7 +1,7 @@
import { COMMAND_MENU_DEFAULT_ICON } from '@/workflow/workflow-trigger/constants/CommandMenuDefaultIcon';
import { DatabaseTriggerDefaultLabel } from '@/workflow/workflow-trigger/constants/DatabaseTriggerDefaultLabel'; import { DatabaseTriggerDefaultLabel } from '@/workflow/workflow-trigger/constants/DatabaseTriggerDefaultLabel';
import { generatedMockObjectMetadataItems } from '~/testing/mock-data/generatedMockObjectMetadataItems'; import { generatedMockObjectMetadataItems } from '~/testing/mock-data/generatedMockObjectMetadataItems';
import { getTriggerDefaultDefinition } from '../getTriggerDefaultDefinition'; import { getTriggerDefaultDefinition } from '../getTriggerDefaultDefinition';
import { COMMAND_MENU_DEFAULT_ICON } from '@/workflow/workflow-trigger/constants/CommandMenuDefaultIcon';
describe('getTriggerDefaultDefinition', () => { describe('getTriggerDefaultDefinition', () => {
it('throws if the activeNonSystemObjectMetadataItems list is empty', () => { it('throws if the activeNonSystemObjectMetadataItems list is empty', () => {
@ -23,7 +23,7 @@ describe('getTriggerDefaultDefinition', () => {
}), }),
).toStrictEqual({ ).toStrictEqual({
type: 'DATABASE_EVENT', type: 'DATABASE_EVENT',
name: 'Record is Created', name: 'Record is created',
settings: { settings: {
eventName: `${generatedMockObjectMetadataItems[0].nameSingular}.created`, eventName: `${generatedMockObjectMetadataItems[0].nameSingular}.created`,
outputSchema: {}, outputSchema: {},
@ -40,7 +40,7 @@ describe('getTriggerDefaultDefinition', () => {
}), }),
).toStrictEqual({ ).toStrictEqual({
type: 'DATABASE_EVENT', type: 'DATABASE_EVENT',
name: 'Record is Updated', name: 'Record is updated',
settings: { settings: {
eventName: `${generatedMockObjectMetadataItems[0].nameSingular}.updated`, eventName: `${generatedMockObjectMetadataItems[0].nameSingular}.updated`,
outputSchema: {}, outputSchema: {},
@ -57,7 +57,7 @@ describe('getTriggerDefaultDefinition', () => {
}), }),
).toStrictEqual({ ).toStrictEqual({
type: 'DATABASE_EVENT', type: 'DATABASE_EVENT',
name: 'Record is Deleted', name: 'Record is deleted',
settings: { settings: {
eventName: `${generatedMockObjectMetadataItems[0].nameSingular}.deleted`, eventName: `${generatedMockObjectMetadataItems[0].nameSingular}.deleted`,
outputSchema: {}, outputSchema: {},
@ -74,7 +74,7 @@ describe('getTriggerDefaultDefinition', () => {
}), }),
).toStrictEqual({ ).toStrictEqual({
type: 'DATABASE_EVENT', type: 'DATABASE_EVENT',
name: 'Record is Created', name: 'Record is created',
settings: { settings: {
eventName: `${generatedMockObjectMetadataItems[0].nameSingular}.created`, eventName: `${generatedMockObjectMetadataItems[0].nameSingular}.created`,
outputSchema: {}, outputSchema: {},

10
packages/twenty-front/src/modules/workflow/workflow-trigger/utils/__tests__/getTriggerDefaultLabel.test.ts
View File

@ -4,7 +4,7 @@ import { getTriggerDefaultLabel } from '../getTriggerLabel';
describe('getTriggerDefaultLabel', () => { describe('getTriggerDefaultLabel', () => {
describe('DATABASE_EVENT triggers', () => { describe('DATABASE_EVENT triggers', () => {
it('returns "Record is Created" for created event', () => { it('returns "Record is created" for created event', () => {
const trigger: WorkflowTrigger = { const trigger: WorkflowTrigger = {
type: 'DATABASE_EVENT', type: 'DATABASE_EVENT',
name: 'Company Created', name: 'Company Created',
@ -19,7 +19,7 @@ describe('getTriggerDefaultLabel', () => {
expect(result).toBe(DatabaseTriggerDefaultLabel.RECORD_IS_CREATED); expect(result).toBe(DatabaseTriggerDefaultLabel.RECORD_IS_CREATED);
}); });
it('returns "Record is Updated" for updated event', () => { it('returns "Record is updated" for updated event', () => {
const trigger: WorkflowTrigger = { const trigger: WorkflowTrigger = {
type: 'DATABASE_EVENT', type: 'DATABASE_EVENT',
name: 'Company Updated', name: 'Company Updated',
@ -34,7 +34,7 @@ describe('getTriggerDefaultLabel', () => {
expect(result).toBe(DatabaseTriggerDefaultLabel.RECORD_IS_UPDATED); expect(result).toBe(DatabaseTriggerDefaultLabel.RECORD_IS_UPDATED);
}); });
it('returns "Record is Deleted" for deleted event', () => { it('returns "Record is deleted" for deleted event', () => {
const trigger: WorkflowTrigger = { const trigger: WorkflowTrigger = {
type: 'DATABASE_EVENT', type: 'DATABASE_EVENT',
name: 'Company Deleted', name: 'Company Deleted',
@ -99,7 +99,7 @@ describe('getTriggerDefaultLabel', () => {
}); });
describe('CRON triggers', () => { describe('CRON triggers', () => {
it('returns "On a Schedule" for cron trigger', () => { it('returns "On a schedule" for cron trigger', () => {
const trigger: WorkflowTrigger = { const trigger: WorkflowTrigger = {
type: 'CRON', type: 'CRON',
name: 'Scheduled Trigger', name: 'Scheduled Trigger',
@ -116,7 +116,7 @@ describe('getTriggerDefaultLabel', () => {
const result = getTriggerDefaultLabel(trigger); const result = getTriggerDefaultLabel(trigger);
expect(result).toBe('On a Schedule'); expect(result).toBe('On a schedule');
}); });
}); });

2
packages/twenty-front/src/modules/workflow/workflow-variables/utils/__tests__/getTriggerStepName.test.ts
View File

@ -10,7 +10,7 @@ it('returns the expected name for a DATABASE_EVENT trigger', () => {
outputSchema: {}, outputSchema: {},
}, },
}), }),
).toBe('Record is Created'); ).toBe('Record is created');
}); });
it('returns the expected name for a MANUAL trigger without a defined objectType', () => { it('returns the expected name for a MANUAL trigger without a defined objectType', () => {

2
packages/twenty-front/src/modules/workflow/workflow-variables/utils/getTriggerStepName.ts
View File

@ -11,7 +11,7 @@ export const getTriggerStepName = (trigger: WorkflowTrigger): string => {
case 'DATABASE_EVENT': case 'DATABASE_EVENT':
return getDatabaseEventTriggerStepName(trigger); return getDatabaseEventTriggerStepName(trigger);
case 'CRON': case 'CRON':
return 'On a Schedule'; return 'On a schedule';
case 'WEBHOOK': case 'WEBHOOK':
return 'Webhook'; return 'Webhook';
case 'MANUAL': case 'MANUAL':