Fix storybook stories (#10853)

Small PR to fix flaky stories
This commit is contained in:
Charles Bochet
2025-03-13 15:19:20 +01:00
committed by GitHub
parent 794110f9dd
commit a2004e6220
5 changed files with 14 additions and 22 deletions

View File

@ -1,5 +1,5 @@
import { Meta, StoryObj } from '@storybook/react';
import { expect, fn, userEvent, within } from '@storybook/test';
import { expect, fn, userEvent, waitFor, within } from '@storybook/test';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { WorkflowStepDecorator } from '~/testing/decorators/WorkflowStepDecorator';
import { MOCKED_STEP_ID } from '~/testing/mock-data/workflow';
@ -68,8 +68,11 @@ export const Disabled: Story = {
play: async ({ canvasElement, args }) => {
const canvas = within(canvasElement);
const editor = canvasElement.querySelector('.ProseMirror > p');
expect(editor).toBeVisible();
const editor = await waitFor(() => {
const editor = canvasElement.querySelector('.ProseMirror > p');
expect(editor).toBeVisible();
return editor;
});
const defaultValue = await canvas.findByText('tim@twenty.com');
expect(defaultValue).toBeVisible();

View File

@ -185,9 +185,11 @@ export const DisabledWithVariable: Story = {
readonly: true,
},
play: async ({ canvasElement }) => {
const editor = canvasElement.querySelector('.ProseMirror > p');
expect(editor).toBeVisible();
const editor = await waitFor(() => {
const editor = canvasElement.querySelector('.ProseMirror > p');
expect(editor).toBeVisible();
return editor;
});
await waitFor(() => {
expect(editor).toHaveTextContent('test Name test');

View File

@ -58,7 +58,7 @@ export const WithExpandedList: Story = {
const rootCanvas = within(root);
const chipCount = await rootCanvas.findByText('+3');
const chipCount = await rootCanvas.findByText('+2');
await userEvent.click(chipCount);

View File

@ -159,12 +159,9 @@ export const DisabledWithDefaultStaticValues: Story = {
await userEvent.click(objectSelectCurrentValue);
{
const searchInputInSelectDropdown =
canvas.queryByPlaceholderText('Search');
const searchInputInSelectDropdown = canvas.queryByPlaceholderText('Search');
expect(searchInputInSelectDropdown).not.toBeInTheDocument();
}
expect(searchInputInSelectDropdown).not.toBeInTheDocument();
const selectedRecord = await canvas.findByText(
`${peopleMock.name.firstName} ${peopleMock.name.lastName}`,

View File

@ -1,5 +1,4 @@
import { Meta, StoryObj } from '@storybook/react';
import { userEvent, within } from '@storybook/test';
import {
PageDecorator,
@ -27,12 +26,3 @@ export default meta;
export type Story = StoryObj<typeof SettingsProfile>;
export const Default: Story = {};
export const LogOut: Story = {
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
const logoutButton = await canvas.findByText('Logout');
await userEvent.click(logoutButton);
},
};